fix(card-template-editor): keep all content above the keyboard - #21805
Merged
Merged
Conversation
Contributor
|
Snapshot diff report vs
All 3 changed screenshotsCardTemplateEditorScreenshotTest
|
david-allison
commented
Sep 9, 2026
| binding.bottomNavigation.isVisible = !softwareKeyboardVisible | ||
| val bottomInset = insets.getInsets(systemBars() or displayCutout() or ime()).bottom | ||
| view.updatePadding( | ||
| bottom = if (softwareKeyboardVisible) bottomInset else 0, |
Member
Author
There was a problem hiding this comment.
I was considering:
top = if (softwareKeyboardVisible) 0 else initial.padding.top, But for smaller templates, the reduction of padding felt like too much of a layout shift
This comment was marked as resolved.
This comment was marked as resolved.
Apply keyboard insets to the bottom navigation so all content is visible Add regression coverage for phones, tablets and switching cards. Fixes 21795 Assisted-by: GPT-6 - all Assisted-by: Claude Opus 5 - text fixup
david-allison
force-pushed
the
21795
branch
from
September 11, 2026 19:35
e620a05 to
c534086
Compare
mikehardy
approved these changes
Sep 18, 2026
mikehardy
left a comment
mikehardy
left a comment
Member
There was a problem hiding this comment.
tough to review - the screenshots were a difficult to parse, but it looked good when I pulled it locally for verify
mikehardy
added
Pending Merge
github-actions
Bot
removed
the
Pending Merge
Member
Author
That's not ideal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: GPT-6 - all
Fixes
Approach
Apply keyboard insets to the bottom navigation so all content is visible
Add regression coverage for phones, tablets and switching cards.
How Has This Been Tested?
Phyiscal test on an API 37 emulator
Screenshot tests: [snipped due to edits; see output below]
Checklist