Fix/20508 unbury dialog - #21818
Fix/20508 unbury dialog#21818
Conversation
|
the code doesn't match the PR body |
7ccb887 to
41f7930
Compare
Sorry about that! I had a minor git mix up and accidentally pushed the code from my other branch when I initially opened this PR. I've just force pushed the correct UI changes so the code now perfectly matches the description. Let me know what you think! |
|
Just to confirm:
I don't believe this is (or should be)
Ah... my misreading here |
Sorry i didnt get your comment |
|
Could I confirm where the reference to |
I was reading through the android material design 3 guidelines to understand how standard dialog titles are styled differently from body text, and the documentation refers to the default dialog title typography as titleLarge. I included the term in the description just to explain why switching to setTitle() made the font bigger, but I realize it made it sound like I explicitly added that exact token into the codebase! Sorry about the confusion. |
Purpose / Description
This PR addresses the "What would you like to unbury?" dialog UI task mentioned in #20508.
Previously, this dialog used a custom
listItemsAndMessage()builder which passed the title text as a standard dialog message (body text) and used a custom layout for the list items that had bold text.Fixes
Approach
To improve the dialog styling and match Material Design guidelines:
setTitle(), making the title correctly utilize the largertitleLargetypography.listItems(), removing the bold styling from the dialog options.How Has This Been Tested?
Tested locally on an Android emulator.
Here is the screenshots of new UI
Checklist
Please, go through these checks before submitting the PR.