Skip to content

Fix/20508 unbury dialog - #21818

Merged
BrayanDSO merged 1 commit into
ankidroid:mainfrom
Ratnesh5:fix/20508-unbury-dialog
Sep 12, 2026
Merged

BrayanDSO merged 1 commit into
ankidroid:mainfrom
Ratnesh5:fix/20508-unbury-dialog

Conversation

@Ratnesh5

Copy link
Copy Markdown
Contributor

Purpose / Description

This PR addresses the "What would you like to unbury?" dialog UI task mentioned in #20508.
Previously, this dialog used a custom listItemsAndMessage() builder which passed the title text as a standard dialog message (body text) and used a custom layout for the list items that had bold text.

Fixes

Approach

To improve the dialog styling and match Material Design guidelines:

  1. Replaced the custom message body text with standard setTitle(), making the title correctly utilize the larger titleLarge typography.
  2. Replaced the custom list builder with standard listItems(), removing the bold styling from the dialog options.

How Has This Been Tested?

Tested locally on an Android emulator.

  1. Enabled Bury new siblings and Bury review siblings in Deck Options.
  2. Added a Basic and a reversed card to a test deck.
  3. Buried the Basic card and answered the reversed card.
  4. Finished the deck and clicked the review counts to access the Congratulations Screen.
  5. Tapped "unbury them" and verified the new UI.
    Here is the screenshots of new UI
WhatsApp Image 2026-09-11 at 21 37 43 Screenshot_20260911_212859

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Sep 11, 2026
@david-allison

Copy link
Copy Markdown
Member

the code doesn't match the PR body

@Ratnesh5
Ratnesh5 force-pushed the fix/20508-unbury-dialog branch from 7ccb887 to 41f7930 Compare September 11, 2026 18:04
@Ratnesh5

Copy link
Copy Markdown
Contributor Author

the code doesn't match the PR body

Sorry about that! I had a minor git mix up and accidentally pushed the code from my other branch when I initially opened this PR. I've just force pushed the correct UI changes so the code now perfectly matches the description. Let me know what you think!

@david-allison

david-allison commented Sep 11, 2026

Copy link
Copy Markdown
Member

Just to confirm:

Replaced the custom message body text with standard setTitle(), making the title correctly utilize the larger titleLarge typography.

I don't believe this is (or should be) titleLarge

> and used a custom layout for the list items that had bold text.

Ah... my misreading here

@Ratnesh5

Copy link
Copy Markdown
Contributor Author

Just to confirm:

Replaced the custom message body text with standard setTitle(), making the title correctly utilize the larger titleLarge typography.

I don't believe this is (or should be) titleLarge

> and used a custom layout for the list items that had bold text.

Ah... my misreading here

Sorry i didnt get your comment
Is everything fine or do i need to change anything?

@david-allison

Copy link
Copy Markdown
Member

Could I confirm where the reference to titleLarge came from?

@Ratnesh5

Copy link
Copy Markdown
Contributor Author

Could I confirm where the reference to titleLarge came from?

I was reading through the android material design 3 guidelines to understand how standard dialog titles are styled differently from body text, and the documentation refers to the default dialog title typography as titleLarge. I included the term in the description just to explain why switching to setTitle() made the font bigger, but I realize it made it sound like I explicitly added that exact token into the codebase! Sorry about the confusion.

@david-allison david-allison left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Optional: adding a screenshot test for this dialog would be fantastic. This does not in any way block the PR

Cheers!

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author Needs Review labels Sep 11, 2026
@BrayanDSO
BrayanDSO added this pull request to the merge queue Sep 12, 2026
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Sep 12, 2026
Merged via the queue into ankidroid:main with commit 1405d2d Sep 12, 2026
24 of 25 checks passed
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Sep 12, 2026
@github-actions github-actions Bot added this to the 2.25 release milestone Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve some dialogs (mostly string changes)

3 participants