Skip to content

fix(media-check) use current theme colors - #21819

Merged
criticalAY merged 2 commits into
ankidroid:mainfrom
david-allison:18594
Sep 11, 2026
Merged

fix(media-check) use current theme colors#21819
criticalAY merged 2 commits into
ankidroid:mainfrom
david-allison:18594

Conversation

@david-allison

@david-allison david-allison commented Sep 11, 2026

Copy link
Copy Markdown
Member

Note

This PR was part of the swe-productivity research study.
My review was performed: swe-productivity#11
I have cherry-picked these commits and fixed up compile errors due to conflicts


Purpose / Description

The MediaCheck screen uses a web view, but doesn't apply and styling to the view. I've added some simple syling,
pulling colors from the current theme.

Fixes

Approach

I added code to fetch the text and background colors from the current theme, and add them to the inline
styles in the HTML content.

How Has This Been Tested?

Reproduction steps:

  • From the main view, select Check > Check Media from the overflow menu
  • Select Ok in the prompt

The media check view previously always showed black text on a white background, but with these changes, it
now uses the text and background colors from the currently selected theme.

Before:
image

After
image

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

cranberry-platypus and others added 2 commits September 11, 2026 18:49
Co-authored-by: David Allison <62114487+david-allison@users.noreply.github.com>
@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Sep 11, 2026

@criticalAY criticalAY left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@criticalAY
criticalAY added this pull request to the merge queue Sep 11, 2026
Merged via the queue into ankidroid:main with commit c3c2d3f Sep 11, 2026
21 checks passed
@github-actions github-actions Bot added this to the 2.25 release milestone Sep 11, 2026
@github-actions github-actions Bot removed the Needs Second Approval Has one approval, one more approval to merge label Sep 11, 2026
@david-allison
david-allison deleted the 18594 branch September 11, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check media background doesn't match the theme

3 participants