Skip to content

feat: Cardbrowser progress adoption - #21821

Open
criticalAY wants to merge 2 commits into
ankidroid:mainfrom
criticalAY:cardbrowser-progress-adoption
Open

criticalAY wants to merge 2 commits into
ankidroid:mainfrom
criticalAY:cardbrowser-progress-adoption

Conversation

@criticalAY

Copy link
Copy Markdown
Contributor

Purpose / Description

Before, the Card Browser fragment wrapped each ViewModel call in the old UI-side withProgress, and some ViewModel methods returned a Job or Deferred only so the fragment could wrap them. Now the ViewModel reports its own progress and the fragment observes it once.

Fixes

Approach

See commits

How Has This Been Tested?

Added tests and here is a test recording:
Screen_recording_20260912_005643.webm

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison

Copy link
Copy Markdown
Member

Could we hold off on this one until 2.25 is stable?

@criticalAY

Copy link
Copy Markdown
Contributor Author

Sure!! we can sorry saw this now (already worked on DeckPicker-PR's up but ofc we can wait)

@david-allison

Copy link
Copy Markdown
Member

Cheers! Could we draft & label the PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants