feat: Cardbrowser progress adoption - #21821
Open
criticalAY wants to merge 2 commits into
Open
criticalAY wants to merge 2 commits into
criticalAY wants to merge 2 commits into
Conversation
Assisted-by: Claude Opus 5 (tests)
Assisted-by: Claude Opus 5 (tests)
Member
|
Could we hold off on this one until 2.25 is stable? |
Contributor
Author
|
Sure!! we can sorry saw this now (already worked on DeckPicker-PR's up but ofc we can wait) |
Member
|
Cheers! Could we draft & label the PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Before, the Card Browser fragment wrapped each ViewModel call in the old UI-side withProgress, and some ViewModel methods returned a Job or Deferred only so the fragment could wrap them. Now the ViewModel reports its own progress and the fragment observes it once.
Fixes
withProgressin ViewModels #19460Approach
See commits
How Has This Been Tested?
Added tests and here is a test recording:
Screen_recording_20260912_005643.webm
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.