test(reminders): AddEditReminderDialog screenshot tests

[david-allison]

Note

Assisted-by: GPT-6; Claude Opus 5

Fixes

• Part of Review reminders: comprehensive screenshot and instrumented tests #21753

Approach

Refactors and add tests - heavy agentic work on code quality here

How Has This Been Tested?

All tests - let's see the results 🥳

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[github-actions]

Snapshot diff report vs main. Open screenshot-diff for diffs.

• AddEditReminderDialogScreenshotTest: 9 changes

All 9 changed screenshots

AddEditReminderDialogScreenshotTest

• add_mode_advanced_open_compare.png
• add_mode_compare.png
• edit_mode_advanced_open_compare.png
• edit_mode_compare.png
• timePicker_12h_compare.png
• timePicker_24h_compare.png
• timePicker_landscape_12h_compare.png
• timePicker_landscape_24h_compare.png
• timePicker_textEntry_compare.png

[ericli3690]

Awesome! Thank you very much!

With that, I think that's a very comprehensive suite of screenshot tests for review reminders. Only instrumented tests left in scope for this associated issue.

I'll merge this. It's essentially test only and I don't think we need to wait for a second review.

[ericli3690]

Uh oh haha conflict

[david-allison]

I'll take this to completion tomorrow, thanks for the review

[david-allison]

Test-only, let's get this in!