fix(card-template-editor): dismiss keyboard before 'discard changes' - #21825
Open
david-allison wants to merge 4 commits into
Open
fix(card-template-editor): dismiss keyboard before 'discard changes'#21825david-allison wants to merge 4 commits into
david-allison wants to merge 4 commits into
Conversation
Assisted-by: GPT-6
Assisted-by: Claude Opus 5
david-allison
force-pushed
the
21807
branch
from
September 11, 2026 23:50
fca020d to
70e771c
Compare
david-allison
added
the
Needs Author Reply
A software keyboard hides the Front/Back/Styling tabs, so 'back' should dismiss it to reveal them. Fixes 21807 GPT-6 wrote the fix; Claude Opus 5 - fixups/review Assisted-by: GPT-6 - fix Assisted-by: Claude Opus 5 - fixups/review
Deleting a card type changes the pager's item IDs so an `ord` lookup failed. Discovered due to 21807 Assisted-by: GPT-6
david-allison
force-pushed
the
21807
branch
from
September 12, 2026 10:45
70e771c to
f65f801
Compare
david-allison
removed
the
Needs Author Reply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: GPT-6
Fixes
Approach
A number of abstractions were tested, and I settled on
isKeyboardOpen, plus a few pre-refactors.After this, it exposed a bug in
currentFragment, which I fixedHow Has This Been Tested?
Heavily unit tested
Checklist