Repository navigation
ci(nightly): stop the Compiler.Tests property soak running the owner-only MutationCensus (fixes #2392) - #2393
Merged
Conversation
…-only MutationCensus — its own SHARPY_CENSUS=1 opt-in, and the nightly filter excludes Category=Census (fixes #2392) Both scheduled Nightly runs (40270167659, 40450595456) died the same way: the 20 min --blame-hang-timeout killed MutationCensus.DrawnCodes_PerLaneAndBase. The nightly sets SHARPY_PROPERTY_ITER=600 to raise the injection lanes' sample count, and that one variable also switched on the census, a report (Category=Property, so the filter selected it) of 87 Sample calls. Under CsCheck_Time=15 that is ~22 min in ONE test. The soak has never got past it. - PropertyIterations: SHARPY_CENSUS (CensusRequested) is the census's own opt-in; SHARPY_PROPERTY_ITER keeps one meaning, the sample count. - MutationCensus: skips unless SHARPY_CENSUS=1; samples Injection per row. - nightly.yml: filter "(Category=RandomProperty|Category=Property)&Category!=Census" (Census tags only MutationCensus), which covers dev until this reaches it. - gap-discovery-contracts.md: the census row names the new opt-in. Verified by direction against the prior commit (a8a8904): - base, SHARPY_PROPERTY_ITER=1 + old filter: census selected and Passed (the bug) - base, new filter: "No test matches" (the filter alone excludes it) - this commit, SHARPY_PROPERTY_ITER=600 alone: census Skipped - this commit, SHARPY_CENSUS=1 SHARPY_PROPERTY_ITER=1 SHARPY_CENSUS_FILTER=ExitArity: Passed - PropertyOracleConformanceTests + TypedGeneratorRosterTests: 13/0/0 @ this commit (measured) The whole-solution gate was not run: the change is one SkippableFact's gate, a workflow filter and two doc lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGMKZWGRTb8vMmx8Gg4wUE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2392.
Why
Both scheduled Nightly runs (40270167659, 40450595456) failed the same way in
properties (Sharpy.Compiler.Tests): the 20 min--blame-hang-timeoutkilledMutationCensus.DrawnCodes_PerLaneAndBase.The nightly sets
SHARPY_PROPERTY_ITER=600to raise the injection lanes' sample count. That same variable was also the census's on-switch. The census is taggedCategory=Property, so the nightly filter selected it. It makes 87Samplecalls, which underCsCheck_Time=15is about 22 min in one test. The soak has never got past it, so everyPropertySerialtest scheduled after the census has had no nightly coverage.What changes
PropertyIterations: addsSHARPY_CENSUS(CensusRequested), the census's own opt-in.SHARPY_PROPERTY_ITERkeeps one meaning: the sample count.MutationCensus: skips unlessSHARPY_CENSUS=1, and samplesPropertyIterations.Injectionper row. The owner workflow becomesSHARPY_CENSUS=1 SHARPY_PROPERTY_ITER=600(plusSHARPY_CENSUS_FILTER/SHARPY_CENSUS_OUTas before).nightly.yml: the filter becomes(Category=RandomProperty|Category=Property)&Category!=Census. OnlyMutationCensushas that tag. The nightly soaksdev, which won't have the new opt-in until this PR reaches it; the filter keeps the census out until then.gap-discovery-contracts.md: the census row names the new opt-in.Verification (direction against the base commit
a8a8904)SHARPY_PROPERTY_ITER=1, old filterNo test matchesSHARPY_PROPERTY_ITER=600aloneSHARPY_CENSUS=1 SHARPY_PROPERTY_ITER=1 SHARPY_CENSUS_FILTER=ExitArityPropertyOracleConformanceTests+TypedGeneratorRosterTests: 13/0/0 @ 64f1c21 (measured). The workflow YAML parses. I did not run the whole-solution gate: the change touches oneSkippableFact's gate, a workflow filter and one doc line.After merge: trigger the Nightly manually. The Compiler.Tests job should finish, its TRX should have no
MutationCensusrow, and more than 2898 tests should pass (the tests after the census will run for the first time).Generated by Claude Code