feat!(go): split Flight SQL into its own module - #4754
Conversation
ed14bd0 to
259a74f
Compare
|
I wonder if I should just move driverbase to be part of flightsql (since we don't really expect to export it anyways) to get the OpenTelemetry dependency out of core, or even use the thirdparty driverbase fork |
I think that's fine since we have we have https://github.com/adbc-drivers/driverbase-go |
|
Ah, but we still have |
This way we don't leak CVEs/dependencies from the driver into the core ADBC package. Breaking changes: - package go/adbc/driver/flightsql => go/flightsql - package go/adbc/sqldriver/flightsql => go/flightsql/sqldriver Also, `driverbase` is now exposed. Closes apache#4623.
|
Alright, that gets gRPC entirely out of the core API...we still depend on the core/trace OTel packages, but they seem to have minimal dependencies, and we still have Protobuf due to some error metadata definitions, but that should also hopefully be OK. |
|
You're going to need to update the release scripts to add a new tag when we do releases in addition to the |
|
Hmm, how is this supposed to work with the go.mod override? Rust/Cargo handles this properly with workspaces, but I suppose for a release we need to remove the override and point at the new tag? |
This way we don't leak CVEs/dependencies from the driver into the core ADBC package.
Breaking changes:
TODOs
Closes #4623.