Skip to content

[Flight SQL] Add client-side tests for Substrait prepared statements #1267

Description

@ennuite

Describe the enhancement requested

Add client-side test coverage for Substrait prepared statements in arrow/flight/flightsql/client_test.go.

PR #732 added server-side coverage for CreatePreparedSubstraitPlan, but the review discussion identified that the corresponding client path has no dedicated tests.

The tests should cover:

  • Client.PrepareSubstrait constructing a CreatePreparedSubstraitPlan action with the supplied plan bytes and Substrait version.
  • Parsing the returned prepared-statement handle and schemas.
  • Preserving all three is_update states: absent, false, and true.
  • Txn.PrepareSubstrait request construction, including the transaction ID, if it is not already covered through shared helpers.

Query and update execution do not need duplicate coverage here: after prepared-statement creation, Substrait and SQL use the same Flight SQL execution paths.

Component(s)

Integration

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions