Skip to content

Nullness improvements for Combine, Min, Max - #39988

Merged
kennknowles merged 1 commit into
apache:masterfrom
kennknowles:Combine-nullness
Sep 4, 2026
Merged

Nullness improvements for Combine, Min, Max#39988
kennknowles merged 1 commit into
apache:masterfrom
kennknowles:Combine-nullness

Conversation

@kennknowles

Copy link
Copy Markdown
Member

This is a fairly small one, re-adding nullness checking to Combine and a couple specific combiners.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions Bot added the java label Sep 3, 2026
@kennknowles

Copy link
Copy Markdown
Member Author

Hmm, actually I think I lost the thread on this one - I'm pretty sure identity() should not be @Nullable T but rather the accumulator type has to be nullable if the combiner doesn't have a natural identity.

@kennknowles

Copy link
Copy Markdown
Member Author

Ah, it turns out this is very hard to change - the mistake dates back to the beginning of Combine where we deliberately made all identities nullable and there is no way around it. So, the current PR isn't adding any nullability.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @ahmedabu98 for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@ahmedabu98 ahmedabu98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennknowles

Copy link
Copy Markdown
Member Author

Ran internal test suite as well.

@kennknowles
kennknowles merged commit e79e231 into apache:master Sep 4, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants