Skip to content

Refactor: delete dead SplitAndSizeRestrictions handling from FnApiDoFnRunner - #39990

Open
kennknowles wants to merge 1 commit into
apache:masterfrom
kennknowles:FnApiDoFnRunner
Open

Refactor: delete dead SplitAndSizeRestrictions handling from FnApiDoFnRunner#39990
kennknowles wants to merge 1 commit into
apache:masterfrom
kennknowles:FnApiDoFnRunner

Conversation

@kennknowles

Copy link
Copy Markdown
Member

The registrar only registers PAR_DO and
SPLITTABLE_PROCESS_SIZED_ELEMENTS_AND_RESTRICTIONS, so the SPLITTABLE_SPLIT_AND_SIZE_RESTRICTIONS cases are unreachable now that that stage has its own runner. Also collapse the two branches of the SDF-process consumer, which constructed identical objects regardless of whether windows were observed; the TODO for a non-window-observing variant is retained.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions Bot added the java label Sep 3, 2026
@kennknowles

Copy link
Copy Markdown
Member Author

R: @scwhittle

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

…nRunner

The registrar only registers PAR_DO and
SPLITTABLE_PROCESS_SIZED_ELEMENTS_AND_RESTRICTIONS, so the
SPLITTABLE_SPLIT_AND_SIZE_RESTRICTIONS cases are unreachable now that
that stage has its own runner. Also collapse the two branches of the
SDF-process consumer, which constructed identical objects regardless of
whether windows were observed; the TODO for a non-window-observing
variant is retained.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.40%. Comparing base (d3ccb3a) to head (e9c37d5).
⚠️ Report is 27 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #39990      +/-   ##
============================================
+ Coverage     55.06%   58.40%   +3.33%     
- Complexity     1722    13548   +11826     
============================================
  Files          1075     2573    +1498     
  Lines        171589   268862   +97273     
  Branches       1262    11046    +9784     
============================================
+ Hits          94482   157021   +62539     
- Misses        74837   105896   +31059     
- Partials       2270     5945    +3675     
Flag Coverage Δ
java 64.58% <100.00%> (-3.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant