Refactor: delete dead SplitAndSizeRestrictions handling from FnApiDoFnRunner - #39990
Open
kennknowles wants to merge 1 commit into
Open
Refactor: delete dead SplitAndSizeRestrictions handling from FnApiDoFnRunner#39990kennknowles wants to merge 1 commit into
kennknowles wants to merge 1 commit into
Conversation
Member
Author
|
R: @scwhittle |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
…nRunner The registrar only registers PAR_DO and SPLITTABLE_PROCESS_SIZED_ELEMENTS_AND_RESTRICTIONS, so the SPLITTABLE_SPLIT_AND_SIZE_RESTRICTIONS cases are unreachable now that that stage has its own runner. Also collapse the two branches of the SDF-process consumer, which constructed identical objects regardless of whether windows were observed; the TODO for a non-window-observing variant is retained. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
kennknowles
force-pushed
the
FnApiDoFnRunner
branch
from
September 3, 2026 16:32
dddc1c2 to
e9c37d5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39990 +/- ##
============================================
+ Coverage 55.06% 58.40% +3.33%
- Complexity 1722 13548 +11826
============================================
Files 1075 2573 +1498
Lines 171589 268862 +97273
Branches 1262 11046 +9784
============================================
+ Hits 94482 157021 +62539
- Misses 74837 105896 +31059
- Partials 2270 5945 +3675
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registrar only registers
PAR_DOandSPLITTABLE_PROCESS_SIZED_ELEMENTS_AND_RESTRICTIONS, so theSPLITTABLE_SPLIT_AND_SIZE_RESTRICTIONScases are unreachable now that that stage has its own runner. Also collapse the two branches of the SDF-process consumer, which constructed identical objects regardless of whether windows were observed; the TODO for a non-window-observing variant is retained.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.