Fix Bigtable Tests for google-cloud-bigtable >= 2.44.0 - #40029
Open
shunping wants to merge 1 commit into
Open
Conversation
…igtable >= 2.44.0
Collaborator
Author
|
r: @Amar3tto |
shunping
marked this pull request as ready for review
September 5, 2026 03:44
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes unit test and runtime failures in
apache_beam/io/gcp/bigtableio.pywithgoogle-cloud-bigtable >= 2.44.0.In
google-cloud-bigtable >= 2.44.0,DirectRow._get_mutations()returns PythonRowMutationEntrydataclass objects (SetCell,DeleteRangeFromColumn,DeleteAllFromFamily,DeleteAllFromRow) instead of rawgoogle.cloud.bigtable_v2.types.data.Mutationprotobuf messages. (googleapis/google-cloud-python@990f86e#diff-7f9a11d9f6bc7583fcd21212c25030948b23bcd4ba7c93caa0db6f6b7d886c8bR290)Because these dataclasses do not implement
__contains__, checking oneof fields in_DirectRowMutationsToBeamRow.processraisedAttributeError: '...' object has no attribute '__contains__'.This PR updates
_DirectRowMutationsToBeamRow.processandTestBigtableDirectRowToBeamRowto callDirectRow._get_mutation_pbs()when available to retrieveMutationprotobuf messages, falling back toDirectRow._get_mutations()for oldergoogle-cloud-bigtableversions.fixes #34739