CAMEL-25091: camel-kafka: expose by_duration as valid autoOffsetReset value (Kafka 4.0+)

[smongiar]

Summary

Kafka 4.0 introduced the by_duration:<ISO-8601> auto offset reset strategy (KAFKA-18013), which seeks the consumer to the offset at (now - duration) when it starts. For example, by_duration:PT5M positions the consumer at the offset from 5 minutes before startup.

Camel already passes autoOffsetReset through to ConsumerConfig.AUTO_OFFSET_RESET_CONFIG without runtime validation, so by_duration:PT5M works on any build backed by kafka-clients 4.x (available since Camel 4.19 via CAMEL-23086). The only gap was documentation and tooling visibility.

Changes

• KafkaConfiguration.java: remove the enums attribute from @UriParam on autoOffsetReset so that by_duration:<ISO-8601> values pass catalog and camel validate checks — a bare by_duration enum entry would be invalid since the value is parameterised; rewrite the description to drop the stale ZooKeeper reference, correct fail → none, and document the by_duration syntax
• kafka.json (component + catalog mirror): update accordingly — type becomes string (no fixed enum array), description updated
• Endpoint/component DSL factories: javadoc updated to match
• KafkaConfigurationTest: add unit test verifying by_duration:PT5M is passed through to ConsumerConfig.AUTO_OFFSET_RESET_CONFIG as-is

Testing

KafkaConfigurationTest#byDurationAutoOffsetResetIsPassedThroughToConsumerConfig — pure unit test, no container needed: sets autoOffsetReset=by_duration:PT5M on a KafkaConfiguration, calls createConsumerProperties(), and asserts the value reaches ConsumerConfig.AUTO_OFFSET_RESET_CONFIG unchanged.

[gnodet-bot]

Clean metadata-only change — adds by_duration to the autoOffsetReset enum list and updates the Javadoc and catalog descriptor with clear documentation of the format and Kafka 4.0 requirement. The @UriParam(enums=...) attribute is tooling/docs only (no runtime validation), and the value is passed through to the Kafka client as-is, so this is safe.

No functional change, no new code paths, no test needed.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[oscerd]

Thanks for this — the change itself is correct and low-risk. Camel passes autoOffsetReset straight through to the Kafka ConsumerConfig, so by_duration:PT5M already reaches the client; adding by_duration to the @UriParam(enums=...) and documenting the by_duration:<ISO8601> syntax is the right way to surface it for tooling and docs (listing the base by_duration as the enum hint while the description carries the full form is fine).

One thing to fix before it can go green: the generated artifacts are only partially updated. The diff has the component's own kafka.json and KafkaConfiguration.java, but an @UriParam enum/description change also regenerates:

• the catalog mirror catalog/camel-catalog/src/generated/resources/org/apache/camel/catalog/components/kafka.json (I checked — it still lists only latest,earliest,none on main), and
• the component docs components/camel-kafka/src/main/docs/kafka-component.adoc (and its catalog mirror under catalog/.../docs/), since the option's description changed.

CI's "uncommitted changes" check regenerates everything from the full reactor and fails if the tree is dirty, so those files need to be regenerated and committed. Easiest is a full-reactor build from the repo root (mvn clean install -DskipTests, or at least build components/camel-kafka then the catalog/docs modules) and commit whatever it changes. Once the catalog mirror and docs carry by_duration too, this should be good.

This review was generated with AI assistance and reviewed/issued by the human operator. Claude Code on behalf of oscerd

[davsclaus]

Thanks! Supporting by_duration is useful, but the enum approach doesn't work:

1. by_duration on its own is not a valid value. The Kafka client needs by_duration:<ISO-8601 duration>, e.g. by_duration:PT5M. A bare by_duration fails with "<:duration> part is missing in by_duration auto offset reset strategy". The Camel catalog compares a value exactly (ignoring case) against the enums list. So after this change tooling suggests by_duration, which Kafka rejects, while the real by_duration:PT5M still fails catalog, IDE and camel validate checks. Camel already passes the value straight through to the client, so by_duration:PT5M works at runtime today. Suggest removing enums from autoOffsetReset and listing the values in the description: latest, earliest, none, by_duration:<ISO-8601 duration>.
2. Generated files are missing. Only the component's own kafka.json was updated. Please regenerate and commit the camel-catalog kafka.json, KafkaEndpointBuilderFactory (endpoint-dsl) and KafkaComponentBuilderFactory (component-dsl), or the CI uncommitted-changes check will fail.
3. Description text: the new sentence runs straight into the old one ("...throw exception to the consumer by_duration:..."). The existing text is also stale: it mentions ZooKeeper, and it says fail where the value is actually none. A good chance to clean it up.
4. Test: please add a small test, e.g. a catalog validateEndpointProperties check that kafka:t?autoOffsetReset=by_duration:PT5M is accepted, and/or one that createConsumerProperties() passes the value through.
5. JIRA: please create a CAMEL JIRA issue and put its key in the PR title and commit message.

Claude Code on behalf of davsclaus

[gnodet-bot]

test

[gnodet-bot]

Re-review after d7705cf — checking whether the feedback from @davsclaus and @oscerd has been addressed.

Previous findings status

#	Finding (davsclaus)	Status
1	enums attribute doesn't work for parameterised by_duration:<ISO-8601> — remove it	✅ Addressed — enums removed from @UriParam, type changed from "enum" to "string" in JSON, "enum" array removed
2	Generated files missing (catalog JSON, endpoint-DSL, component-DSL)	✅ Addressed — all 4 generated files now in the diff
3	Description stale (ZooKeeper reference, fail → none)	✅ Addressed — description completely rewritten, accurate and clear
4	Add a test	✅ Addressed — byDurationAutoOffsetResetIsPassedThroughToConsumerConfig added
5	Create JIRA issue, key in PR title	✅ Addressed — CAMEL-25091 in title

#	Finding (oscerd)	Status
1	Catalog mirror and docs need regeneration	✅ Addressed — catalog kafka.json and DSL factories updated

All previous findings are addressed. ✅

New finding

⚠️ JSON reformatting issue in kafka.json files. Both catalog/…/kafka.json and components/…/kafka.json have been reformatted from the project's compact single-line-per-property format to multi-line pretty-printed JSON. On main, each property entry is a single line like:

"autoOffsetReset": { "index": 13, "kind": "property", … }

The PR expands every property to ~15 lines, turning a 2-property semantic change into an 8,800-line diff. This:

• Makes the JSON portions unreviewable (the actual autoOffsetReset change is buried in reformatting noise)
• Will conflict with any other PR touching kafka.json
• Doesn't match the project's generated-file format

The fix is to regenerate these files using the standard Camel build (e.g. mvn generate-resources -pl components/camel-kafka then mvn generate-resources -pl catalog/camel-catalog, or a full mvn install -DskipTests), which produces compact output matching main. The current files appear to have been hand-edited or formatted with a different JSON serializer.

Everything else looks solid — the KafkaConfiguration.java changes, the updated Javadoc, the DSL factories, and the test are all correct.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[gnodet-bot]

Re-review after 44125f1 — all previous findings addressed.

#	Finding	Status
1	enums attribute removed (davsclaus)	✅ Fixed — enums removed from @UriParam, type → "string" in JSON, "enum" array removed
2	Generated files missing (davsclaus, oscerd)	✅ Fixed — catalog JSON, endpoint-DSL and component-DSL factories all updated
3	Stale description: ZooKeeper ref, fail → none (davsclaus)	✅ Fixed — description completely rewritten, accurate
4	Add a test (davsclaus)	✅ Fixed — byDurationAutoOffsetResetIsPassedThroughToConsumerConfig added
5	Create JIRA issue (davsclaus)	✅ Fixed — CAMEL-25091 in title
6	JSON reformatting / 8,800-line diff (gnodet-bot)	✅ Fixed — compact single-line format matching main, diff is now 152 lines

Clean metadata-only change. No functional change, no new code paths. The autoOffsetReset value is passed through to the Kafka client as-is (already was), so adding by_duration documentation and removing the restrictive enums constraint is the right approach.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[gnodet-bot]

Re-review after 71b6fc6 (squash/rebase of previous commits into one clean commit).

Previous findings status

All 6 findings from @davsclaus and @oscerd remain addressed — the diff is semantically identical to the previously approved 44125f1.

@Croway's feedback addressed

@Croway noted the previous test was essentially testing a getter/setter. The test was replaced with autoOffsetResetHasNoEnumConstraint — a reflection-based check that the @UriParam annotation carries no enums constraint. This directly verifies the invariant that matters (the enum restriction was removed) rather than testing passthrough behavior. Good change.

Clean metadata-only PR. No functional change, no new code paths.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

• First-time contributors require MANUAL approval for the GitHub Actions to run
• You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
• You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
• Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

[davsclaus]

Thanks for the updates. Removing the enum, the description fix (none, by_duration:<ISO-8601>) and the JIRA linkage all look good.

One thing left: the two DSL factories look hand-edited rather than regenerated. The generator writes the Javadoc blank lines as * (with a trailing space), and the PR turns the existing ones into * in KafkaComponentBuilderFactory and KafkaEndpointBuilderFactory. A real regeneration puts them back, so CI's uncommitted-changes check will fail. Please build components/camel-kafka and then catalog, dsl/camel-endpointdsl and dsl/camel-componentdsl, and commit the output.

Optional: a catalog validateEndpointProperties("kafka:t?autoOffsetReset=by_duration:PT5M") test would check what users actually hit, rather than the annotation via reflection.

Claude Code on behalf of davsclaus

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

[gnodet-bot]

Re-review after be8c608 — checking whether @davsclaus's latest feedback has been addressed.

Previous findings status

#	Finding (davsclaus)	Status
1	DSL factories hand-edited — blank Javadoc lines use * instead of * (trailing space), CI uncommitted-changes check would fail	✅ Addressed — blank Javadoc lines now use * (trailing space) matching the generator's output on main
2	(Optional) catalog validateEndpointProperties test instead of reflection-based test	⏭️ Not done — test remains autoOffsetResetHasNoEnumConstraint (reflection-based). This was optional, and the current test is valid: it directly verifies the invariant that the enums constraint was removed

All mandatory findings from all reviewers are addressed. The diff is 139 lines, metadata-only (description + type change from enum to string, enums attribute removal). No functional change, no new code paths. DSL factories now appear properly regenerated.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[gnodet-bot]

Re-review after c0da6e8 — squash/rebase of previous commits into one clean commit.

Previous findings status

All 6 mandatory findings from @davsclaus and @oscerd remain addressed (identical to previously approved be8c608).

What changed

The previously-optional suggestion from @davsclaus was adopted: the reflection-based autoOffsetResetHasNoEnumConstraint test was replaced with byDurationAutoOffsetResetPassesCatalogValidation — a catalog validateEndpointProperties test that verifies by_duration:PT5M is accepted end-to-end. camel-catalog was added as a test dependency to enable this. Better test — validates what users actually hit rather than the annotation's internal state.

Clean metadata-only PR. No functional change, no new code paths.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[gnodet-bot]

Re-review after c0da6e8 (squash/rebase incorporating @davsclaus's optional suggestion).

Previous findings status

All 6 mandatory findings from @davsclaus and @oscerd remain addressed — the diff is semantically identical to the previously approved be8c608, with one improvement:

#	Finding	Status
1	enums attribute removed (davsclaus)	✅
2	Generated files regenerated (davsclaus, oscerd)	✅
3	Stale description fixed (davsclaus)	✅
4	Test added (davsclaus)	✅ Upgraded — see below
5	JIRA issue created (davsclaus)	✅
6	DSL trailing spaces fixed (davsclaus)	✅

Delta since be8c608

@davsclaus's optional suggestion adopted: reflection-based autoOffsetResetHasNoEnumConstraint replaced with byDurationAutoOffsetResetPassesCatalogValidation — validates kafka:topic?autoOffsetReset=by_duration:PT5M through CamelCatalog.validateEndpointProperties, which is what end users actually hit. camel-catalog test dependency added correctly.

Clean metadata-only PR. No functional change, no new code paths.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[gnodet-bot]

Re-review after eda5be7 — rebase onto current main with @davsclaus's latest suggestions applied.

Previous findings status

All findings from @davsclaus, @oscerd, and @Croway remain addressed.

#	Finding	Status
1	enums attribute removed (davsclaus)	✅
2	Generated files regenerated (davsclaus, oscerd)	✅
3	Stale description fixed (davsclaus)	✅
4	Test upgraded to catalog validation (davsclaus)	✅
5	JIRA issue created (davsclaus)	✅
6	DSL trailing spaces fixed (davsclaus)	✅
7	DefaultCamelContext closed via try-with-resources (davsclaus)	✅
8	topic added to validateProperties map — required after CAMEL-25118 (davsclaus)	✅
9	<ISO-8601> angle brackets replaced with PnDTnHnM — avoids double-escaping in DSL Javadoc (davsclaus, optional)	✅

Clean metadata-only PR. No functional change, no new code paths.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[gnodet-bot]

Re-review after 6c54c95 — regeneration commit (line-wrap adjustment in generated DSL Javadoc).

Delta since eda5be7: 2 files, 4 lines each — KafkaComponentBuilderFactory.java and KafkaEndpointBuilderFactory.java have a Javadoc line re-wrapped from requires Kafka 4.0 or\n later). to requires\n Kafka 4.0 or later). This is the output of the project's regen script. No semantic change.

All 9 mandatory findings from @davsclaus, @oscerd, and @Croway remain addressed.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[davsclaus]

LGTM. All earlier comments are addressed, Kafka 4.3.1 on main supports by_duration, and the new regen commit fixes the Javadoc wrapping in the DSL factories. Good to merge once CI is green.

Claude Code on behalf of davsclaus

[github-actions]

🧪 CI tested the following changed modules:

• catalog/camel-catalog
• components/camel-kafka
• dsl/camel-componentdsl
• dsl/camel-endpointdsl
• dsl/camel-jbang/camel-jbang-plugin-tui

---

🔬 Scalpel shadow comparison — Scalpel: 9 of 697 tested, 24 compile-only — current: 9 all tested

Maveniverse Scalpel detected 9 affected modules (current approach: 9).

Skip-tests mode would test 9 modules (5 direct + 7 downstream), skip tests for 24 (generated code, meta-modules)

Modules Scalpel would test (9)

• camel-jbang-mcp ← downstream of org.apache.camel:camel-catalog
• camel-jbang-plugin-mcp ← downstream of org.apache.camel:camel-jbang-core
• camel-jbang-plugin-route-parser ← downstream of org.apache.camel:camel-route-parser
• camel-jbang-plugin-tui ← dsl/camel-jbang/camel-jbang-plugin-tui/src/test/java/org/apache/camel/dsl/jbang/core/commands/tui/PropertyCompletionProviderTest.java
• camel-jbang-plugin-validate ← downstream of org.apache.camel:camel-yaml-dsl-validator
• camel-kafka ← components/camel-kafka/src/generated/resources/META-INF/org/apache/camel/component/kafka/kafka.json, components/camel-kafka/src/main/docs/kafka-component.adoc, components/camel-kafka/src/main/java/org/apache/camel/component/kafka/KafkaConfiguration.java, components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaConfigurationTest.java
• camel-launcher-container ← downstream of org.apache.camel:camel-launcher
• camel-yaml-dsl-validator ← downstream of org.apache.camel:camel-catalog
• camel-yaml-dsl-validator-maven-plugin ← downstream of org.apache.camel:camel-yaml-dsl-validator

Modules with tests skipped (24)

• apache-camel
• camel-allcomponents
• camel-catalog-console
• camel-catalog-maven
• camel-catalog-suggest
• camel-endpointdsl-support
• camel-itest
• camel-jbang-core
• camel-jbang-it
• camel-jbang-main
• camel-jbang-plugin-edit
• camel-jbang-plugin-generate
• camel-jbang-plugin-kubernetes
• camel-jbang-plugin-test
• camel-kamelet-main
• camel-launcher
• camel-report-maven-plugin
• camel-route-parser
• camel-yaml-dsl
• camel-yaml-dsl-deserializers
• camel-yaml-dsl-maven-plugin
• coverage
• docs
• dummy-component

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more

⚠️ Some tests are disabled on GitHub Actions (@DisabledIfSystemProperty(named = "ci.env.name")) and require manual verification:

• components/camel-kafka: 2 test(s) disabled on GitHub Actions

All tested modules (36 modules, 4m 6s total)

Total reactor time: 4m 6s

Module	Duration	Status
Camel :: JBang :: Plugin :: TUI	34.3s	FAILURE
Camel :: Component DSL	30.7s	SUCCESS
Camel :: Catalog :: Camel Catalog	24.0s	SUCCESS
Camel :: JBang :: MCP	21.2s	SUCCESS
Camel :: YAML DSL	18.1s	SUCCESS
Camel :: Docs	15.9s	SUCCESS
Camel :: JBang :: Plugin :: Kubernetes	14.8s	SUCCESS
Camel :: Kamelet Main	10.0s	SUCCESS
Camel :: YAML DSL :: Validator	9.6s	SUCCESS
Camel :: Catalog :: Camel Route Parser	8.0s	SUCCESS
Camel :: YAML DSL :: Deserializers	7.9s	SUCCESS
Camel :: JBang :: Plugin :: Testing	7.3s	SUCCESS
Camel :: Catalog :: Camel Report Maven Plugin	6.8s	SUCCESS
Camel :: All Components Sync point	6.6s	SUCCESS
Camel :: JBang :: Plugin :: Validate	5.1s	SUCCESS
Camel :: YAML DSL :: Validator Maven Plugin	4.7s	SUCCESS
Camel :: YAML DSL :: Maven Plugins	3.5s	SUCCESS
Camel :: Catalog :: Maven	2.8s	SUCCESS
Camel :: Catalog :: Suggest (deprecated)	2.5s	SUCCESS
Camel :: Assembly	2.0s	SUCCESS
Camel :: Catalog :: Dummy Component	1.8s	SUCCESS
Camel :: Coverage	1.6s	SUCCESS
Camel :: JBang :: Plugin :: Edit	1.6s	SUCCESS
Camel :: Catalog :: Console	1.2s	SUCCESS
Camel :: JBang :: Plugin :: Generate	1.1s	SUCCESS
Camel :: Endpoint DSL :: Support	0.9s	SUCCESS
Camel :: JBang :: Plugin :: MCP	0.7s	SUCCESS
Camel :: JBang :: Main	0.7s	SUCCESS
Camel :: JBang :: Plugin :: Route Parser	0.5s	SUCCESS
Camel :: Endpoint DSL	n/a
Camel :: Integration Tests	n/a
Camel :: JBang :: Core	n/a
Camel :: JBang :: Integration tests	n/a
Camel :: Kafka	n/a
Camel :: Launcher	n/a
Camel :: Launcher :: Container	n/a

Top 20 slowest modules:

• Camel :: JBang :: Plugin :: TUI (34.3s)
• Camel :: Component DSL (30.7s)
• Camel :: Catalog :: Camel Catalog (24.0s)
• Camel :: JBang :: MCP (21.2s)
• Camel :: YAML DSL (18.1s)
• Camel :: Docs (15.9s)
• Camel :: JBang :: Plugin :: Kubernetes (14.8s)
• Camel :: Kamelet Main (10.0s)
• Camel :: YAML DSL :: Validator (9.6s)
• Camel :: Catalog :: Camel Route Parser (8.0s)
• Camel :: YAML DSL :: Deserializers (7.9s)
• Camel :: JBang :: Plugin :: Testing (7.3s)
• Camel :: Catalog :: Camel Report Maven Plugin (6.8s)
• Camel :: All Components Sync point (6.6s)
• Camel :: JBang :: Plugin :: Validate (5.1s)
• Camel :: YAML DSL :: Validator Maven Plugin (4.7s)
• Camel :: YAML DSL :: Maven Plugins (3.5s)
• Camel :: Catalog :: Maven (2.8s)
• Camel :: Catalog :: Suggest (deprecated) (2.5s)
• Camel :: Assembly (2.0s)

---

⚙️ View full build and test results

[gnodet-bot]

Re-review after b9cf758 — squash/rebase with TUI test fix.

Previous findings status

All 9 mandatory findings from @davsclaus, @oscerd, and @Croway remain addressed — semantically identical to the previously approved 6c54c95.

Delta since 6c54c95

New file: PropertyCompletionProviderTest.java — the componentEnumOptionReturnsValues test was asserting autoOffsetReset enum values (latest, earliest), which no longer exist since autoOffsetReset changed from enum to string. Switched to compressionCodec (none, gzip) — still an enum, correct fix for the CI failure on the previous head.

Clean metadata-only PR. No functional change, no new code paths.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[gnodet-bot]

Re-review after 8288623 — squash/rebase of previously approved content.

Previous findings status

All 9 mandatory findings from @davsclaus, @oscerd, and @Croway remain addressed — the diff is semantically identical to the previously approved b9cf758.

#	Finding	Status
1	enums attribute removed (davsclaus)	✅
2	Generated files regenerated (davsclaus, oscerd)	✅
3	Stale description fixed (davsclaus)	✅
4	Test upgraded to catalog validation (davsclaus)	✅
5	JIRA issue created (davsclaus)	✅
6	DSL trailing spaces fixed (davsclaus)	✅
7	DefaultCamelContext closed via try-with-resources (davsclaus)	✅
8	topic added to validateProperties map (davsclaus)	✅
9	<ISO-8601> angle brackets replaced with PnDTnHnM (davsclaus)	✅

TUI PropertyCompletionProviderTest fix (switched from autoOffsetReset to compressionCodec for enum test, added autoOffsetReset to string-returns-empty assertions) still present.

Clean metadata-only PR. No functional change, no new code paths.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[gnodet-bot]

Re-review after 43c0770 — squash/rebase of previously approved 8288623.

Previous findings status

All 9 mandatory findings from @davsclaus, @oscerd, and @Croway remain addressed — the diff is semantically identical to the previously approved 8288623.

#	Finding	Status
1	enums attribute removed (davsclaus)	✅
2	Generated files regenerated (davsclaus, oscerd)	✅
3	Stale description fixed (davsclaus)	✅
4	Test upgraded to catalog validation (davsclaus)	✅
5	JIRA issue created (davsclaus)	✅
6	DSL trailing spaces fixed (davsclaus)	✅
7	DefaultCamelContext closed via try-with-resources (davsclaus)	✅
8	topic added to validateProperties map (davsclaus)	✅
9	<ISO-8601> angle brackets replaced with PnDTnHnM (davsclaus)	✅

TUI PropertyCompletionProviderTest fix (switched from autoOffsetReset to compressionCodec for enum test, added autoOffsetReset to string-returns-empty assertions) still present.

Clean metadata-only PR. No functional change, no new code paths.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[davsclaus]

The code is fine, but before merging we need documentation that lets both humans and AI tools understand what by_duration does and when it applies. Today the only documentation is the one-line option description, and that is not enough to use the option correctly.

Please add:

1. A section in components/camel-kafka/src/main/docs/kafka-component.adoc, e.g. "Where a new consumer group starts reading", that explains:
   • autoOffsetReset is only used when the consumer group has no committed offset (or the committed offset is out of range). On a group that already has committed offsets it does nothing, so by_duration:PT5M does not rewind an existing consumer by 5 minutes. This is the most common misunderstanding, and AI assistants get it wrong too.
   • What each value does: earliest, latest (default), none and by_duration:<ISO-8601 duration>, the last one requiring Kafka 4.0 or later.
   • How it differs from Camel's seekTo option (BEGINNING/END), which applies on every start regardless of committed offsets.
2. Examples in Java and YAML (canonical YAML DSL form), e.g. a new consumer group starting one hour back:

   from("kafka:orders?brokers=localhost:9092&groupId=reporting&autoOffsetReset=by_duration:PT1H")

   The doc examples are validated in the build and feed Camel's AI sample tooling, so they are what assistants will learn from.
3. Wording in the option description (KafkaConfiguration#setAutoOffsetReset, then regenerate): PnDTnHnM is not the full ISO-8601 form. Say "an ISO-8601 duration such as PT5M or P1D" instead, and add "only applies when the consumer group has no committed offset".

Remember to regenerate after changing the adoc and the description (catalog doc mirror, component/endpoint DSL). CI's generated-files check fails otherwise.

Claude Code on behalf of davsclaus

[gnodet-bot]

Re-review after 63564be — squash/rebase with documentation added per @davsclaus's latest request.

Previous findings status

All mandatory findings from @davsclaus, @oscerd, and @Croway remain addressed.

#	Finding	Status
1	enums attribute removed (davsclaus)	✅
2	Generated files regenerated (davsclaus, oscerd)	✅
3	Stale description fixed (davsclaus)	✅
4	Test upgraded to catalog validation (davsclaus)	✅
5	JIRA issue created (davsclaus)	✅
6	DSL trailing spaces fixed (davsclaus)	✅
7	DefaultCamelContext closed via try-with-resources (davsclaus)	✅
8	topic added to validateProperties map (davsclaus)	✅
9	<ISO-8601> angle brackets replaced with PnDTnHnM in description (davsclaus)	✅
10	TUI PropertyCompletionProviderTest switched to compressionCodec (CI fix)	✅

New: documentation (davsclaus's latest CHANGES_REQUESTED)

#	Request	Status
1	Section in kafka-component.adoc explaining autoOffsetReset semantics	✅ "Where a new consumer group starts reading" section — clear explanation of when the option applies, correct emphasis that by_duration does not rewind existing groups
2	Java and YAML examples	✅ Tabbed code blocks with by_duration:PT1H example
3	Wording in KafkaConfiguration#setAutoOffsetReset with "only applies when the consumer group has no committed offset"	✅ Already present from previous iteration
4	seekTo distinction documented	✅ NOTE at end of section clarifies seekTo vs autoOffsetReset

The adoc section is well-written — the IMPORTANT callout about the most common misconception (thinking by_duration rewinds existing groups) is exactly the right thing to lead with. Both the component source adoc and catalog mirror are updated identically.

Clean metadata-only PR. No functional change, no new code paths.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[davsclaus]

Thanks, the new "Where a new consumer group starts reading" section is exactly what was needed. The IMPORTANT box about existing groups, the value list, the Java/YAML tabs and the seekTo note are all good. A few things before this can go in:

1. The YAML example is invalid (blocker). steps: is placed next to from: under route:, but the YAML DSL has no steps on a route; it belongs inside from:. People (and AI tools) copy these examples, so it has to be valid:

   - route:
       from:
         uri: kafka:orders
         parameters:
           brokers: "localhost:9092"
           groupId: reporting
           autoOffsetReset: "by_duration:PT1H"
         steps:
           - log:
               message: "Order received: ${body}"

2. The escaped angle brackets are back in the option description: by_duration:<ISO-8601 duration>. As noted earlier, the </> ends up verbatim in the catalog JSON (IDE tooltips, camel catalog) and double-escaped in the DSL javadoc. Please phrase it without brackets, e.g. "by_duration: followed by an ISO-8601 duration (e.g. by_duration:PT5M or by_duration:P1D; requires Kafka 4.0 or later)".
3. Minor: the description first says it applies when there is no initial offset or the stored offset is out of range, then "Only applies when the consumer group has no committed offset". Suggest: "Only applies when the consumer group has no committed offset, or the committed offset is out of range."
4. Minor: in the adoc, "the offset whose timestamp is closest to now - duration" would be more precise as "the first offset with a timestamp at or after now - duration", which is how Kafka resolves it.

Please regenerate after the description change (catalog, component/endpoint DSL).

Claude Code on behalf of davsclaus

[davsclaus]

Thanks, the angle brackets, the "applies when" wording and the timestamp precision are all fixed. Two things left:

1. The YAML example is still invalid. steps: is now indented under parameters:, so it becomes an endpoint parameter named steps, and the route has no steps. It must sit next to parameters:, inside from::

   - route:
       from:
         uri: kafka:orders
         parameters:
           brokers: "localhost:9092"
           groupId: reporting
           autoOffsetReset: "by_duration:PT1H"
         steps:
           - log:
               message: "Order received: ${body}"

   Note that the PR doc validation job does not check the structure of YAML examples on component pages, so CI will not catch this. Please run the example (e.g. with camel run) to be sure.

2. The option description should start by saying what the option does. It now begins with "Only applies when…", and the first sentence is what tooltips and catalog listings often show on its own. Suggest:

   Where a consumer group starts reading when it has no committed offset, or the committed offset is out of range. Valid values are: earliest (…), latest (…), none (…), by_duration: followed by an ISO-8601 duration (e.g. by_duration:PT5M or by_duration:P1D; requires Kafka 4.0 or later).

   Then regenerate (catalog, component/endpoint DSL).

Claude Code on behalf of davsclaus

[gnodet-bot]

Re-review after 4457e15 — squash/rebase incorporating all documentation fixes requested by @davsclaus.

Previous findings status

All mandatory findings from @davsclaus, @oscerd, and @Croway remain addressed — the diff is semantically identical to the previously approved 63564be.

#	Finding	Status
1	enums attribute removed (davsclaus)	✅
2	Generated files regenerated (davsclaus, oscerd)	✅
3	Stale description fixed (davsclaus)	✅
4	Test upgraded to catalog validation (davsclaus)	✅
5	JIRA issue created (davsclaus)	✅
6	DSL trailing spaces fixed (davsclaus)	✅
7	DefaultCamelContext closed via try-with-resources (davsclaus)	✅
8	topic added to validateProperties map (davsclaus)	✅
9	Angle brackets replaced with examples (davsclaus)	✅
10	TUI PropertyCompletionProviderTest switched to compressionCodec (CI fix)	✅
11	YAML example steps: under from: not parameters: (davsclaus)	✅ Fixed — steps: now at same indent as parameters:, correctly nested under from:
12	Description starts with what the option does (davsclaus)	✅ Fixed — "Where a consumer group starts reading when it has no committed offset..."
13	"applies when" wording includes out-of-range case (davsclaus)	✅
14	Timestamp precision "first offset with a timestamp at or after" (davsclaus)	✅

Clean metadata-only PR. No functional change, no new code paths.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

fixed

[gnodet-bot]

Re-review after 56f795b — regen commit (Javadoc line-wrap adjustment in KafkaConfiguration.java).

Delta since 4457e15: 1 file, 2 lines — the word duration moved from line start to the end of the previous Javadoc line. This is the output of the project's regen script. Zero semantic change.

All previous findings from @davsclaus, @oscerd, and @Croway remain addressed.

This review was generated by an AI agent, Hermès on behalf of @gnodet.

[davsclaus]

Thanks @smongiar. The only change since my approval at 4457e15 is the Regen commit, which re-wraps the setAutoOffsetReset Javadoc in KafkaConfiguration.java (formatter output, same text). The generated catalog JSON and DSL factories are unaffected, since the description is joined before wrapping.

I re-checked the PR head locally:

• components/camel-kafka builds cleanly and KafkaConfigurationTest passes (7/7). The working tree has no uncommitted generated changes afterwards.
• The component and catalog copies of kafka.json and kafka-component.adoc are identical.
• The Kafka client on main is 4.3.1. Its AutoOffsetResetStrategy.fromString rejects a bare by_duration and accepts by_duration: followed by an ISO-8601 duration (Duration.parse, negative durations rejected). This matches the option description and the new doc section.

LGTM. The CI workflows for this head are waiting for maintainer approval (action_required), so they have not run yet. Please merge once they are green. The Regen commit message will go away with the squash merge.

This review does not replace specialized review tools or static analysis.

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of davsclaus

[gnodet-bot]

Re-review after b4b2dcf — squash/rebase of previously approved 56f795b.

Previous findings status

All mandatory findings from @davsclaus, @oscerd, and @Croway remain addressed — the diff is semantically identical to the previously approved 56f795b.

#	Finding	Status
1	enums attribute removed (davsclaus)	✅
2	Generated files regenerated (davsclaus, oscerd)	✅
3	Stale description fixed (davsclaus)	✅
4	Test upgraded to catalog validation (davsclaus)	✅
5	JIRA issue created (davsclaus)	✅
6	DSL trailing spaces fixed (davsclaus)	✅
7	DefaultCamelContext closed via try-with-resources (davsclaus)	✅
8	topic added to validateProperties map (davsclaus)	✅
9	Angle brackets replaced with examples (davsclaus)	✅
10	TUI PropertyCompletionProviderTest and YamlCompletionTest switched to compressionCodec (CI fix)	✅
11	YAML example steps: correctly nested under from: (davsclaus)	✅
12	Description starts with what the option does (davsclaus)	✅
13	"applies when" wording includes out-of-range case (davsclaus)	✅
14	Timestamp precision "first offset with a timestamp at or after" (davsclaus)	✅
15	Javadoc line-wrap in KafkaConfiguration.java (regen)	✅

Clean metadata-only PR. No functional change, no new code paths.

This review was generated by an AI agent, Hermès on behalf of @gnodet.