enabling resize volume Api validation notification errors to be shown in UI - #14220
Open
sathvikaragi wants to merge 1 commit into
Open
sathvikaragi wants to merge 1 commit into
sathvikaragi wants to merge 1 commit into
Conversation
#103) …how up in UI ### Description When resizing a volume, backend API validation errors (e.g. invalid size value) are silently swallowed and never shown to the user. This PR... <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> File: ui/src/views/storage/ResizeVolume.vue, lines 147–151 The .catch() handler uses this.$notification.error() with a hardcoded path error.response.data.errorresponse.errortext. However, the CloudStack API only uses errorresponse as the response key for unknown commands. For known commands like resizeVolume, it uses the command's own response name (resizevolumeresponse) as the key. So error.response.data.errorresponse is always undefined, causing a silent TypeError that swallows the error entirely. $notifyError avoids this by using _.findKey() to find errortext regardless of what the key is named — which is why the same validation error shows correctly in UpdatePrimaryStorage.vue (which uses $notifyError) but not in ResizeVolume.vue. <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [X] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? <img width="1470" height="760" alt="Screenshot 2026-09-16 at 12 30 24 PM" src="https://github.com/user-attachments/assets/f1d993a9-0a5d-4273-9e43-a0ac4838f355" /> <img width="1473" height="827" alt="Screenshot 2026-09-16 at 1 07 53 PM" src="https://github.com/user-attachments/assets/1c900a1d-4978-43ec-ba9d-62fce2f0aac3" /> <img width="1470" height="771" alt="Screenshot 2026-09-16 at 1 08 07 PM" src="https://github.com/user-attachments/assets/8bcf3fac-5b35-427b-ad26-6fe7588d5a72" /> <img width="1473" height="799" alt="Screenshot 2026-09-16 at 1 08 24 PM" src="https://github.com/user-attachments/assets/d0aea139-8d4d-4620-a7d7-ef294a5335c9" /> <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
sathvikaragi
marked this pull request as ready for review
September 22, 2026 06:26
Author
Contributor
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14220 +/- ##
============================================
- Coverage 19.91% 19.90% -0.02%
+ Complexity 20200 20196 -4
============================================
Files 6373 6373
Lines 577230 577230
Branches 70696 70696
============================================
- Hits 114974 114905 -69
- Misses 449690 449768 +78
+ Partials 12566 12557 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When resizing a volume, backend API validation errors (e.g. invalid size value) are silently swallowed and never shown to the user.
This PR...
Fixes: #14222
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?