Reword KVM VM snapshot without memory error message - #6387
Conversation
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
weizhouapache
left a comment
weizhouapache
left a comment
There was a problem hiding this comment.
code lgtm
@nvazquez you missed the new screenshot (with this pr).
|
UI build: ✔️ |
|
Done @weizhouapache thanks |
|
@blueorangutan package |
|
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Kudos, SonarCloud Quality Gate passed! |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3398 |
|
@blueorangutan test |
|
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-4178)
|
sureshanaparti
changed the title
| try { | ||
| vmsnapshot = _vmSnapshotService.allocVMSnapshot(getVmId(), getDisplayName(), getDescription(), snapshotMemory()); | ||
| } catch (CloudRuntimeException e) { | ||
| throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed to create vm snapshot: " + e.getMessage(), e); |
There was a problem hiding this comment.
| throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed to create vm snapshot: " + e.getMessage(), e); | |
| throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed to create VM snapshot: " + e.getMessage(), e); |
7 participants
Description
This PR throws a more descriptive error on KVM in case the snapshot type is not supported (tested on KVM + snapshot memory = false):
Before:
After:
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?