Skip to content

cks: Get caller user keys if cluster belongs to project - #6392

Merged
nvazquez merged 2 commits into
apache:mainfrom
shapeblue:fix-cks-autoscale-proj
May 18, 2022
Merged

nvazquez merged 2 commits into
apache:mainfrom
shapeblue:fix-cks-autoscale-proj

Conversation

@davidjumani

Copy link
Copy Markdown
Contributor

Description

Fixes #6344
Passes the caller's API keys if the cluster is part of a project

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

autoscaler logs :

I0516 08:57:51.486442       1 static_autoscaler.go:235] Starting main loop
I0516 08:57:51.487030       1 client.go:169] NewAPIRequest API request URL:http://10.0.32.136:8080/client/api?apiKey=***&command=listKubernetesClusters&id=a5e617a3-6d95-410c-9d3a-306274ee8b11&response=json&signature=***
I0516 08:57:51.515655       1 client.go:175] NewAPIRequest response status code:200
I0516 08:57:51.518415       1 cloudstack_manager.go:88] Got cluster : &{a5e617a3-6d95-410c-9d3a-306274ee8b11 cluster 1 2 1 1 [0xc000716f90 0xc000716fc0] map[cluster-control-180cc02282f:0xc000716f90 cluster-node-180cc025111:0xc000716fc0]}

@acs-robot

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@davidjumani
davidjumani force-pushed the fix-cks-autoscale-proj branch from 6ba84d0 to 8d2bc29 Compare May 16, 2022 09:29
@davidjumani

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@acs-robot

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6392 (SL-JID-1576)

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3413

@davidjumani

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-4194)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42672 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6392-t4194-kvm-centos7.zip
Smoke tests completed. 95 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Failure 466.03 test_vpc_redundant.py

@yadvr yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't test it

@yadvr
yadvr requested review from Pearl1594, nvazquez and shwstppr May 17, 2022 10:41

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache weizhouapache added this to the 4.17.0.0 milestone May 17, 2022
@weizhouapache

Copy link
Copy Markdown
Member

cc @nvazquez

@davidjumani

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@acs-robot

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@shwstppr

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sureshanaparti sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3425

@weizhouapache

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@nvazquez
nvazquez merged commit 5fdd4d2 into apache:main May 18, 2022
@davidjumani
davidjumani deleted the fix-cks-autoscale-proj branch May 18, 2022 16:40
@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-4202)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35813 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6392-t4202-kvm-centos7.zip
Smoke tests completed. 97 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

User kubeadmin is not getting created except for default project in k8s cluster

8 participants