Skip to content

Log exception on keystore build for custom certificate #6394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvazquez merged 2 commits into from
May 18, 2022
Merged

Log exception on keystore build for custom certificate #6394

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47e3b03
Log exception on keystore build for custom certificate
nvazquez May 17, 2022
c87af21
Refactor
nvazquez May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions .../src/main/java/org/apache/cloudstack/framework/security/keystore/KeystoreManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,16 +108,12 @@ public byte[] getKeystoreBits(String name, String aliasForCertificateInStore, St

try {
return CertificateHelper.buildAndSaveKeystore(certs, storePassword);
} catch (KeyStoreException e) {
s_logger.warn("Unable to build keystore for " + name + " due to KeyStoreException");
} catch (CertificateException e) {
s_logger.warn("Unable to build keystore for " + name + " due to CertificateException");
} catch (NoSuchAlgorithmException e) {
s_logger.warn("Unable to build keystore for " + name + " due to NoSuchAlgorithmException");
} catch (InvalidKeySpecException e) {
s_logger.warn("Unable to build keystore for " + name + " due to InvalidKeySpecException");
} catch (IOException e) {
s_logger.warn("Unable to build keystore for " + name + " due to IOException");
} catch (KeyStoreException | CertificateException | NoSuchAlgorithmException | InvalidKeySpecException | IOException e) {
String msg = String.format("Unable to build keystore for %s due to %s", name, e.getClass().getSimpleName());
s_logger.warn(msg);
if (s_logger.isDebugEnabled()) {
s_logger.debug(msg, e);
}
}
return null;
}
Expand Down