Prevent NPE on reboot stopped VM and startVM output with null displayname

[nvazquez]

Description

This PR prevents an NPE on VM reboot when the VM is not in Running state.

Also addresses the output of the startVirtualMachine API with null displayname:

(isc-uat) 🐱 > start virtualmachine id=5e549d97-f6c6-4109-9416-ed6eb7c8b912
{
  "accountid": "53c6e98d-bc37-11ec-ba86-02000252074f",
  "cmd": "org.apache.cloudstack.api.command.admin.vm.StartVMCmdByAdmin",
  "completed": "2022-05-17T21:50:25+0000",
  "created": "2022-05-17T21:50:24+0000",
  "jobid": "0ea90ce5-2af2-4268-baed-e189134aad78",
  "jobinstanceid": "5e549d97-f6c6-4109-9416-ed6eb7c8b912",
  "jobinstancetype": "VirtualMachine",
  "jobprocstatus": 0,
  "jobresult": {
    "errorcode": 431,
    "errortext": "The virtual machine 5e549d97-f6c6-4109-9416-ed6eb7c8b912 (null) is already running"
  },
  "jobresultcode": 530,
  "jobresulttype": "object",
  "jobstatus": 2,
  "userid": "9013ef87-e072-492f-a609-32c1f4c18383"
}

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[shwstppr]

Tested. Works okay, a suggestion on exception message

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3438

[slavkap]

Code looks good, didn't test it

[Pearl1594]

LGTM

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✖️ debian ✔️ suse15. SL-JID 3439

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[sureshanaparti]

code LGTM @nvazquez

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3440

[sureshanaparti]

@blueorangutan test

[weizhouapache]

code lgtm

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-4206)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37897 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6397-t4206-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_07_deploy_kubernetes_ha_cluster	Failure	3617.22	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	0.05	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.04	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	64.05	test_kubernetes_clusters.py