UI: fix create vpc private gateway for regular user - #6400
Merged
Merged
Conversation
…d the owner please note (1) isolated networks only . (2) networks in project are not impacted. the tabs are always visible. (3) 'network permission' tab is also only visible for domain/root admin and the owner. but not visible in project view.
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
shwstppr
approved these changes
May 23, 2022
shwstppr
left a comment
shwstppr
left a comment
Contributor
There was a problem hiding this comment.
Tested on QA server, looks okay
Comment on lines
+687
to
700
| if (this.isAdmin()) { | ||
| this.rules = { | ||
| ipaddress: [{ required: true, message: this.$t('label.required') }], | ||
| gateway: [{ required: true, message: this.$t('label.required') }], | ||
| netmask: [{ required: true, message: this.$t('label.required') }] | ||
| } | ||
| } else { | ||
| this.rules = { | ||
| ipaddress: [{ required: true, message: this.$t('label.required') }], | ||
| gateway: [{ required: true, message: this.$t('label.required') }], | ||
| netmask: [{ required: true, message: this.$t('label.required') }], | ||
| associatednetworkid: [{ required: true, message: this.$t('label.required') }] | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (this.isAdmin()) { | |
| this.rules = { | |
| ipaddress: [{ required: true, message: this.$t('label.required') }], | |
| gateway: [{ required: true, message: this.$t('label.required') }], | |
| netmask: [{ required: true, message: this.$t('label.required') }] | |
| } | |
| } else { | |
| this.rules = { | |
| ipaddress: [{ required: true, message: this.$t('label.required') }], | |
| gateway: [{ required: true, message: this.$t('label.required') }], | |
| netmask: [{ required: true, message: this.$t('label.required') }], | |
| associatednetworkid: [{ required: true, message: this.$t('label.required') }] | |
| } | |
| } | |
| this.rules = { | |
| ipaddress: [{ required: true, message: this.$t('label.required') }], | |
| gateway: [{ required: true, message: this.$t('label.required') }], | |
| netmask: [{ required: true, message: this.$t('label.required') }] | |
| } | |
| if (!this.isAdmin()) { | |
| this.rules.associatednetworkid = [{ required: true, message: this.$t('label.required') }] | |
| } |
@weizhouapache can this be simplified?
nvazquez
approved these changes
May 23, 2022
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes ui issues in the form to create vpc private gateway by regular user
This also contains other ui bug fixes below
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?