Skip to content

debian/control: build packages on ubuntu 22.04 - #7269

Merged
DaanHoogland merged 1 commit into
apache:4.18from
weizhouapache:4.18-build-cs-ubuntu22
Apr 17, 2023
Merged

DaanHoogland merged 1 commit into
apache:4.18from
weizhouapache:4.18-build-cs-ubuntu22

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR supports cloudstack packaging on ubuntu 22.04

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache weizhouapache added this to the 4.18.1.0 milestone Feb 21, 2023
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@weizhouapache
weizhouapache marked this pull request as ready for review February 24, 2023 17:48

@kiranchavala kiranchavala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @weizhouapache

Can you make nodejs (>= 14)

Since nodejs 12 is not supported by ubuntu 22.04 release and is deprecated

https://deb.nodesource.com/node_12.x/dists/

There is ubuntu 22.04 -Jammy in node_14.x which is LTS

https://deb.nodesource.com/node_14.x/dists/


Also is "dh-systemd" required for a successful build ?

As per https://bugs.debian.org/822670, the dh-systemd package has been merged with the main debhelper package since version 9.20160709

On Ubuntu 22.04 (Jammy) the dh-systemd package has been completely removed,

@weizhouapache

Copy link
Copy Markdown
Member Author

Hi @weizhouapache

Can you make nodejs (>= 14)

Since nodejs 12 is not supported by ubuntu 22.04 release and is deprecated

https://deb.nodesource.com/node_12.x/dists/

There is ubuntu 22.04 -Jammy in node_14.x which is LTS

https://deb.nodesource.com/node_14.x/dists/

Also is "dh-systemd" required for a successful build ?

As per https://bugs.debian.org/822670, the dh-systemd package has been merged with the main debhelper package since version 9.20160709

On Ubuntu 22.04 (Jammy) the dh-systemd package has been completely removed,

@kiranchavala
thanks for your review.

since debian/control is also used when build package on ubuntu 20.04, it should be compatible with ubuntu 20.04 as well 22.04

for example, dh-systemd | debhelper (>= 13) means both dh-systemd (on ubuntu 20.04) and debhelper (>=13) on ubuntu 22.04 work.

The change for nodejs makes sense. The version has been update in PR #6956
https://github.com/apache/cloudstack/pull/6956/files#diff-6e8c08cff231f603dfa7a4d5f873a6fee6e5c730d431c113bbf5b1180c6983e4

However, I need to check if nodejs verison has been changed in our container for deb packaging.
If it still uses nodejs12, the packaging jobs will fail if this is merged.

@wido

wido commented Mar 22, 2023

Copy link
Copy Markdown
Contributor

Code LGTM

@yadvr
yadvr changed the base branch from main to 4.18 March 29, 2023 14:22
@yadvr

yadvr commented Mar 29, 2023

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@yadvr

yadvr commented Apr 3, 2023

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

@kiranchavala kiranchavala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the Changes LGTM

@DaanHoogland
DaanHoogland merged commit dabefca into apache:4.18 Apr 17, 2023
DaanHoogland added a commit that referenced this pull request Apr 17, 2023
* 4.18:
  debian/control: build packages on ubuntu 22.04 (#7269)
  server,engine-schema: fix listing service offering for vm scale (#7398)
@weizhouapache
weizhouapache deleted the 4.18-build-cs-ubuntu22 branch June 23, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants