utils: fix check for metalink url

[shwstppr]

Description

Fixes condition

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[nvazquez]

LGTM

[codecov]

Codecov Report

Merging #7636 (1e4222c) into 4.18 (03910c2) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.18    #7636   +/-   ##
=========================================
  Coverage     12.98%   12.99%           
- Complexity     8984     8991    +7     
=========================================
  Files          2716     2716           
  Lines        256329   256343   +14     
  Branches      39974    39981    +7     
=========================================
+ Hits          33275    33301   +26     
+ Misses       218892   218875   -17     
- Partials       4162     4167    +5     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[yadvr]

@blueorangutan package

[blueorangutan]

@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6241

[yadvr]

@blueorangutan test

[blueorangutan]

@rohityadavcloud a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-6758)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49372 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7636-t6758-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	Error	81.76	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	56.40	test_vm_life_cycle.py

[DaanHoogland]

code looks good @shwstppr, but what does this fix?

[shwstppr]

code looks good @shwstppr, but what does this fix?

Code

[DaanHoogland]

code looks good @shwstppr, but what does this fix?

Code

haha, no issue no description. why is this?

[shwstppr]

code looks good @shwstppr, but what does this fix?

Code

haha, no issue no description. why is this?

To fix code. I guess most developers should get the fact that the condition that has been changed was originally incorrect.

[shwstppr]

Merging based on tests and 2xLGTM

[DaanHoogland]

code looks good @shwstppr, but what does this fix?

Code

haha, no issue no description. why is this?

To fix code. I guess most developers should get the fact that the condition that has been changed was originally incorrect.

Yes, they should but we are not all developers here and some might want to test this and want to know what behaviourt to look for.