Spec: Align the decimal type string with the canonical form - #18145
Open
moomindani wants to merge 1 commit into
Open
moomindani wants to merge 1 commit into
moomindani wants to merge 1 commit into
Conversation
apache#16798 added the sentence that the type strings in Appendix C's table are the canonical serialized forms, but left the decimal row itself unchanged: the template still omitted the separator space and the examples showed both spacings. Java's DecimalType.toString() writes the spaced form, as does PyIceberg, and apache#16799 already made this change for geography.
github-actions
Bot
added
the
Specification
Contributor
Author
|
@kevinjqliu you wrote #16798 and #16799 on the same day, so this is squarely your call: the decimal row is the one row that #16798's new sentence describes but its diff didn't reach, and #16799 shows what the complete version looks like. One line in the type-string table, no change to reader tolerance, CI is green. Would you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #16798, applying to
decimalwhat #16799 did forgeography.#16798 added the sentence that the type strings in this table are the canonical serialized forms, and its description gives the canonical decimal form as
decimal(P, S), but it left the decimal row itself unchanged: the template still reads"decimal(<P>,<S>)"and the examples still show both spacings. This updates the row to match — one template and one example, both spaced.Java writes that form:
SchemaParserwritestype.toString()andDecimalType.toString()formatsdecimal(%d, %d). PyIceberg emits the same. Reader tolerance for the unspaced form is unchanged — that is stated by the sentence #16798 added.Noticed while working on conformance fixtures for apache/iceberg-verification, where a fixture has to name one canonical form per type string.
Testing
git diff --check