Conversation
Prune schemas referenced only by expired view versions while preserving schemas used by retained versions and standalone schemas.
Author
|
@nastra @huaxingao when you get a chance, could you please take a look at this? Thanks! |
uros-b
reviewed
Sep 21, 2026
Member
There was a problem hiding this comment.
Kudos for much testing here @unikdahal! The logic looks good and safe here, let's wait for further review from expert committers as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18155.
ViewMetadata.Builderlimits retained view versions usingversion.history.num-entries, but previously kept schemas referenced only by versions that were expired. This could cause view metadata to grow over repeated view replacements with evolving schemas.This change prunes schemas that are referenced only by expired view versions while preserving schemas referenced by retained versions and standalone schemas that are not associated with any view version.
Adds regression coverage for schema retention across version expiration, shared schemas, standalone schemas, current versions, and REST-style metadata updates.
AI Disclosure
Model: GPT-5.6 Sol
Platform/Tool: Codex
Human Oversight: reviewed fully
Prompt Summary: Implement and review a fix to prune view schemas referenced only by expired view versions while preserving retained and standalone schemas.