Skip to content

fix(gateways): stop Kafka Produce sends at the request deadline - #4643

Merged
mmodzelewski merged 1 commit into
masterfrom
kafka-produce-deadline
Oct 29, 2026
Merged

mmodzelewski merged 1 commit into
masterfrom
kafka-produce-deadline

Conversation

@krishvishal

Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Oct 25, 2026
@codecov

codecov Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.82%. Comparing base (922c6d1) to head (c482e20).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4643      +/-   ##
============================================
- Coverage     90.86%   90.82%   -0.05%     
- Complexity     3104     3106       +2     
============================================
  Files          1479     1479              
  Lines        361309   361306       -3     
  Branches     305179   305177       -2     
============================================
- Hits         328296   328139     -157     
- Misses        26111    26274     +163     
+ Partials       6902     6893       -9     
Components Coverage Δ
Rust Core 92.14% <ø> (-0.06%) ⬇️
Java SDK 78.14% <ø> (ø)
C# SDK 83.66% <ø> (+0.06%) ⬆️
Python SDK 85.67% <ø> (ø)
PHP SDK 90.71% <ø> (ø)
Node SDK 96.44% <ø> (ø)
Go SDK 69.24% <ø> (-0.07%) ⬇️
C++ SDK 85.55% <ø> (ø)
see 39 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

numinnex
numinnex previously approved these changes Oct 28, 2026
mmodzelewski
mmodzelewski previously approved these changes Oct 28, 2026
A send that outlived its request landed later, so a client retry stored the batch twice; failed sends that wrote nothing answer 6, not -1.
@krishvishal
krishvishal dismissed stale reviews from mmodzelewski and numinnex via c482e20 October 29, 2026 05:31
@krishvishal
krishvishal force-pushed the kafka-produce-deadline branch from 407591a to c482e20 Compare October 29, 2026 05:31
@mmodzelewski
mmodzelewski merged commit 153fdf4 into master Oct 29, 2026
116 checks passed
@mmodzelewski
mmodzelewski deleted the kafka-produce-deadline branch October 29, 2026 06:05
@github-actions github-actions Bot removed the S-waiting-on-review PR is waiting on a reviewer label Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants