Repository navigation
feat(gateways): report Kafka group members' client id and host - #4651
Merged
Merged
Conversation
Member
Author
|
/skill team-review |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #4651 +/- ##
============================================
- Coverage 90.82% 81.15% -9.67%
Complexity 3104 3104
============================================
Files 1479 1479
Lines 361309 361306 -3
Branches 305179 305176 -3
============================================
- Hits 328157 293228 -34929
- Misses 26257 61121 +34864
- Partials 6895 6957 +62
🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary: The DescribeGroups client id and host wiring is correct on the wire path, and the frame pricing, docs and TCP test agree. The one gap is API-level: GroupCoordinator::join() accepts a client_id that only the connection layer caps, though no wire path reaches it.
Counts: critical 0, warning 1, nit 1, simplification 1
This review was generated by Claude Code 2.1.310 on deepseek-flash[1m]. Review the output before you act on it.
github-actions
Bot
added
S-waiting-on-author
numinnex
previously approved these changes
Oct 28, 2026
mmodzelewski
previously approved these changes
Oct 28, 2026
DescribeGroups left CLIENT-ID and HOST empty. A member now keeps the client id and peer address of the connection it last joined through, and its id starts with the client id.
krishvishal
dismissed stale reviews from mmodzelewski and numinnex
via
October 28, 2026 18:12
8273e4e
krishvishal
force-pushed
the
kafka-member-client-id
branch
from
October 28, 2026 18:12
3fbd4cd to
8273e4e
Compare
hubcio
approved these changes
Oct 28, 2026
spetz
approved these changes
Oct 28, 2026
github-actions
Bot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Closes #4511
Rationale
kafka-consumer-groups.sh --describe --membersshowed an empty CLIENT-ID and HOST for every member of a gateway group. Operators use these two columns to find the process behind a consumer. Kafka fills both from theJoinGrouprequest: the client id from the request header, and the host from the address of the connection. The gateway handlers saw neither.What changed?
Each connection now keeps the first client id that a request header names, cut to 1,024 bytes. It also keeps the peer IP address in Kafka's
/10.0.0.7form. A member takes both from the connection that it last joined through, and DescribeGroups reports them. A new member id now starts with the client id, as in Kafka, where it used to start withmember.