Allow concurrent PPMC and IPMC release votes in guides - #147
justinmclean wants to merge 1 commit into
Conversation
Bring the cookbook, release management and graduation guides and the cross-list vote scenario in line with the updated incubation policy, which lets podlings run the dev@ and general@ votes at the same time.
There was a problem hiding this comment.
🟡 Changes recommended
Two documentation inconsistencies should be corrected before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates release documentation and scenario guidance to support sequential or concurrent PPMC and IPMC votes.
Changes:
- Documents vote thresholds and concurrent execution.
- Updates release management and graduation guidance.
- Revises the cross-list voting scenario.
File summaries
| File | Summary | Findings |
|---|---|---|
pages/guides/releasemanagement.ad |
Adds PPMC voting guidance and concurrent options. | Nit: clarify that the majority comparison is among PPMC members. |
pages/guides/graduation.ad |
Clarifies that both approvals are required. | None. |
pages/cookbook/index.ad |
Documents sequential and concurrent PPMC/IPMC votes. | Nit: update the later “two-phase vote” reference to allow concurrent voting. |
assets/scenarios/CrossListReleaseVoteConfusion.html |
Updates scenario instructions and explanations. | None. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| The podling can hold these votes one after the other or, at its discretion, at the same time. The release is approved | ||
| only when both votes have passed. See the link:/policy/incubation.html#releases[Incubation Policy] for details. |
There was a problem hiding this comment.
Confirmed. May search for and edit the "two-phase" expression when needed.
| The podling also votes on the release on its dev list, where at least three +1 votes from PPMC members and more +1 | ||
| than -1 votes are required. The podling can hold the two votes one after the other or at the same time, and the |
There was a problem hiding this comment.
Fair enough to adopt this suggestion. We write:
The vote is successful if there are at least three +1 votes from PPMC members,
and more +1 than -1 votes from PPMC members.
Above.
|
Thanks for preparing this follow-up. I'm looking into it today. |
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Generally LGTM. The two comments from copilot is reasonable or fair enough.
You may search for and edit the "two-phase" expression when needed; or if desired, you can delegate it to me.
Follow-up to #145, which lets podlings run the PPMC vote on dev@ and the IPMC vote on general@ one after the other or at the same time.
This removes wording that assumed the general@ vote only starts after the dev@ vote passes:
Site baked locally; the edited pages render and the policy anchor resolves.