feat(pr-management): with-reviewers: runs model CLIs as adversarial reviewers - #1373
Merged
potiuk merged 3 commits intoSep 24, 2026
Merged
Conversation
potiuk
added this pull request to stack #1374
September 24, 2026 16:52
potiuk
force-pushed
the
feat/adversarial-review-code-review
branch
2 times, most recently
from
September 24, 2026 17:14
0f31415 to
e15a229
Compare
…eviewers pr-management-code-review gains a tool path next to the slash path: `with-reviewers:codex,copilot` (or a configured adversarial-review.md whose mode is not off) has the agent run the adversarial-review tool over the PR at Step 5 and fold the findings in, attributed per reviewer. `with-reviewer:` and Review preferences keep the propose-and-type flow. A private repository's PR asks before the first tool run. Eval suite pr-management-code-review/step-2-reviewer-resolution (6 cases). The implementation plan is folded into the design's As built section and deleted, per docs/designs/README.md. Generated-by: Claude Opus 5
Generated-by: Claude Opus 5
- the tool path reviews --target pr:<N> from an empty temporary directory created once per session: the skill has no checkout of the PR's head, and the maintainer's own checkout must not be readable by other models (a tracker checkout is refused outright); exit 2 skips the tool path for the session - the announcement says where diffs go, rather than promising a prompt that auto-approving harness modes skip - the plugin-missing fallthrough keeps an explicit with-reviewer: - the resolution order is now the same in SKILL.md, selectors.md and adversarial.md as in prerequisites.md §2 - prefetched PRs get Step 5 from the parent (subagents have no shell) - a test pins code-review's copy of the command to the sandbox exclusion; two more resolution eval cases Generated-by: Claude Opus 5
potiuk
force-pushed
the
feat/adversarial-review-code-review
branch
from
September 24, 2026 21:44
e15a229 to
6f5abc4
Compare
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 4 of 4, stacked on #1372. This PR's base is
feat/adversarial-review-pre-pr, so the diff shows only PR 4. Merge #1371 and #1372 first; this PR then retargets tomain. It is the last of the series.Summary
pr-management-code-reviewgains a tool path.with-reviewers:codex,copilothas the agent run the adversarial-review tool over each PR at Step 5. So does a configuredadversarial-review.mdwhosemodeis notoff. The findings are folded in and attributed per reviewer.with-reviewer:<slash command>and "Review preferences" keep today's propose-and-type flow.--target pr:<N>from an empty temporary directory, since the skill has no checkout of the PR's head and the maintainer's own checkout must not be readable by other models. A private repository's PR asks before the first run. The session announcement names the reviewers, so the maintainer knows where diffs go.prerequisites.md§2, andSKILL.md,selectors.mdandadversarial.mdpoint at it. Prefetched PRs get Step 5 from the parent.docs/designs/README.md. The design's status is now "Built".Type of change
.claude/skills/<name>/) — eval fixtures updated belowdocs/,README.md,CONTRIBUTING.md)Test plan
prek run --all-filespassestools/adversarial-reviewpassespytest(144 tests). A test now pins code-review's copy of the command,--repo-dirincluded, to the sandbox exclusion.pr-management-code-review/step-2-reviewer-resolution(8 cases). It covers:with-reviewers:,with-reviewer:, and configon-demand/off;no-adversarial;with-reviewer:and with a config-selected tool path.RFC-AI-0004 compliance
Linked issues
Stacked on #1372 and #1371; follows #1368.
🤖 Generated with Claude Code