Skip to content

Ignore empty unpack type entries #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
efegokdemir wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ignore empty unpack type entries #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
265806b
Ignore empty unpack types
efegokdemir Sep 24, 2026
9c41517
test: cover empty unpack type entries
efegokdemir Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/org/apache/maven/plugins/ear/EarMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,8 @@ private List<String> createUnpackList() throws MojoExecutionException {
List<String> unpackTypesList = new ArrayList<>();
if (unpackTypes != null) {
unpackTypesList = Arrays.asList(unpackTypes.split(","));
unpackTypesList = new ArrayList<>(unpackTypesList);
unpackTypesList.removeIf(String::isEmpty);
for (String type : unpackTypesList) {
if (!EarModuleFactory.isStandardArtifactType(type)) {
throw new MojoExecutionException("Invalid type [" + type + "] supported types are "
Expand Down
20 changes: 20 additions & 0 deletions src/test/java/org/apache/maven/plugins/ear/EarMojoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@
package org.apache.maven.plugins.ear;

import java.io.File;
import java.lang.reflect.Field;
import java.lang.reflect.Method;
import java.util.Arrays;
import java.util.List;

import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;
Expand All @@ -37,6 +40,17 @@ private File invokeGetEarFile(String finalName, String classifier) throws Except
return (File) method.invoke(null, tempDir.getAbsolutePath(), finalName, classifier);
}

@SuppressWarnings("unchecked")
private List<String> invokeCreateUnpackList(String unpackTypes) throws Exception {
EarMojo mojo = new EarMojo(null, null, null, null, null, null);
Field field = EarMojo.class.getDeclaredField("unpackTypes");
field.setAccessible(true);
field.set(mojo, unpackTypes);
Method method = EarMojo.class.getDeclaredMethod("createUnpackList");
method.setAccessible(true);
return (List<String>) method.invoke(mojo);
}

@Test
void testGetEarFileWithNullClassifier() throws Exception {
File result = invokeGetEarFile("myapp", null);
Expand All @@ -54,4 +68,10 @@ void testGetEarFileWithDashPrefixedClassifier() throws Exception {
File result = invokeGetEarFile("myapp", "-sources");
assertEquals(new File(tempDir, "myapp-sources.ear"), result);
}

@Test
void testCreateUnpackListIgnoresEmptyTypes() throws Exception {
assertEquals(Arrays.asList("jar", "war"), invokeCreateUnpackList("jar,war,"));
assertEquals(Arrays.asList("jar", "war"), invokeCreateUnpackList("jar,,war"));
}
}