GH-656: shrink ChannelPipedInputStream buffer after all data is read - #913
Merged
Merged
Conversation
… read Replace compact() with a fresh default-sized ByteArrayBuffer when the pipe is drained, including on EOF with no pending data, so cached SSH sessions do not retain large backing arrays.
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #656
Summary
ByteArrayBufferwith a fresh default-sized buffer instead of callingcompact(), which only resets positions and leaves the large backing array allocatedeof()with no unread data, apply the same shrink so cached SSH sessions do not retain ~512 KB per channel after command completionTest plan
bufferShrinksAfterAllDataReadregression test (64 KiB payload; asserts backing array returns toByteArrayBuffer.DEFAULT_SIZEafter drain + EOF)ChannelPipedInputStreamTestcases passmvn -pl sshd-core -am -DskipTests install -q && mvn -pl sshd-core -Dtest=ChannelPipedInputStreamTest test(Java 21, Maven 3.9.16)Made with Cursor