Repository navigation
[SPARK-60684][CONNECT] Fast-path exact built-in string input #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dbtsai
wants to merge
6
commits into
apache:master
Choose a base branch
from
dbtsai:codex/spark-60684-exact-str
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c8a573b
[SPARK-60684][CONNECT] Fast-path exact built-in string input
dbtsai 7ea45dd
[SPARK-60684][CONNECT] Include string guards in CI-selected offline t…
dbtsai 45dd9bc
[SPARK-60684][CONNECT] Reuse shared mock server in string input tests
dbtsai aad7f70
[SPARK-60684][CONNECT] Decode captured string IPC in tests
dbtsai 67e422b
[SPARK-60684][CONNECT] Clarify compatibility guards and mock capture
dbtsai 8a89df3
Trim exact-string tests to conversion guards
dbtsai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: when UTF-8 extraction fails on an exact
str, the generic path can't succeed. It ends with "unsupported value type for createDataFrame: str", which is misleading. This isn't new and doesn't block the PR, but returning the extraction error here would be simpler and clearer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that preserving the extraction error would be clearer. I left the existing TypeError fallback unchanged to keep this optimization behavior-preserving; the surrogate cases check that compatibility. Propagating the original Unicode error can be a separate behavior change.