TEZ-4677: Upgrades Tez to compile and run with JDK 25#482
Conversation
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
It looks like the Jenkinsfile and Dockerfile have changed and been optimized in the latest commits. I need to rebase with the latest changes and check on this task. @Aggarwal-Raghav, if we want to test Tez with JDK 25, which fields in the latest Jenkinsfile and Dockerfile do we need to modify? As far as I can see in the latest changes, there are no fields related to the JDK version. |
|
@maheshrajus , please check this.
|
|
(!) A patch to the testing environment has been detected. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
@maheshrajus , now the spotbugs have failed because its incompatible with jdk25. I'll investigate it in some time to see which is better approach (maven-shading or apache pom version) from my perspective and share my findings as both have some tradeoffs in terms of error |
|
This much of the patch should be enough. It is passing in local. Regarding Lines 49 to 53 in 17d1549 jdk25.patch |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
LGTM +1 for pom, Dockerfile changes. JDK25 changes look good. For checkstyle plese consult with a committer/PMC whether to do in this PR or separate? |
|
@Aggarwal-Raghav All checkstyle issues related to jdk 25 so better to include in this PR itself. @abstractdog Could you please review the PR at your convenience? |
|
(!) A patch to the testing environment has been detected. |
|
@abstractdog spotbugs checked internally and they are running fine. Could you please review the PR at your convenience? |
|
💔 -1 overall
This message was automatically generated. |
|
@abstractdog @ayushtkn |
|
is this expected in spotbugs? as far as I know, if you change the Dockerfile, it's picked up, so the new spotbugs is supposed to be used |
Uh oh!
There was an error while loading. Please reload this page.