[REFACTOR][IR] Promote primitive bitwise and shift operations to nodes - #20392
Merged
Merged
Conversation
Represent primitive shifts and bitwise expressions with dedicated nodes so traversal, symbolic analysis, rewriting, and code generation share typed operands. Preserve public builders and operators while replacing intrinsic-based dispatch throughout the compiler.
spectrometerHBH
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primitive bitwise and shift expressions currently use generic intrinsic calls, requiring separate matching logic in analysis and lowering. This change introduces LShift, RShift, BitwiseAnd, BitwiseOr, BitwiseXor, and BitwiseNot nodes and migrates compiler consumers to typed operands. Public builders and operators retain their validation and constant-folding behavior.
The migration covers reflection and traversal, Python and TVMScript, symbolic analysis including Z3, Relax and TIR transforms, and C/LLVM/SPIR-V/WebGPU code generation. Existing tests receive representation-only updates.