[FIX][TIRx] Avoid stale constraints from mutable memory predicates - #20393
Merged
Merged
Conversation
tqchen
approved these changes
Sep 20, 2026
MasterJH5574
pushed a commit
that referenced
this pull request
Sep 22, 2026
…20393) This pr fixes incorrect simplification of conditions that read mutable memory. An enclosing branch can currently cause `StmtSimplify` to remove a nested loop bound even when stores inside the branch or loop change the value being tested. Assertions can similarly cause later expressions to be folded incorrectly. Only record pure branch and assertion predicates as analyzer facts, and exclude memory-dependent branch conditions from iteration predicates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes incorrect simplification of conditions that read mutable memory. An enclosing branch can currently cause
StmtSimplifyto remove a nested loop bound even when stores inside the branch or loop change the value being tested. Assertions can similarly cause later expressions to be folded incorrectly.Only record pure branch and assertion predicates as analyzer facts, and exclude memory-dependent branch conditions from iteration predicates.