Conversation
Contributor
|
@Paul-TT I would like you to address this one, please. |
Collaborator
|
@sebbASF @bproffitt Thanks for noticing that. On further inspection, we don't actually don't even want those to have the style of object fit:cover. The style is being overridden by a more specific class anyway using object-fit:contain. I can remove the misspelled classes. |
Contributor
Author
|
There are 6 other instances of object-fit-cover (correctly spelled) in the file: maybe some of those should not be present as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This affects the object-fit setting for project, podlings and sponsor logo images.
The default is fit, which causes images to be stretched to fit if their aspect ratio does not match the container, whereas cover causes clipping [1]
Preview at https://www-objec-fit-cover.staged.apache.org/
Any differences are likely to be quite subtle, but there is no point adding a non-existent class to images.
Either fix the name (as per this PR) or drop it.
[1] https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/object-fit