[mykola-mokhnach]

Command functions were assigned as instance fields, which made them properties: subclasses could not redefine them as methods or call super. Mirror the base-driver layout instead: each command module augments AndroidDriver with method signatures via declare module, and Object.assign(AndroidDriver.prototype, ...) attaches them.

getLogTypes and getLog now live in the class as real overrides using super. Also fix mobileResetGeolocation, which bound resetMockLocation without ever calling it.

[eglitise]

It looks like there's a couple of lint warnings

[Copilot]

🟡 Changes recommended

The central subclass override behavior needs regression coverage, and the intentional duplicate imports need a complete lint suppression.

2 open findings

• Add regression test for subclass command overrides · New
• Extend duplicate-import suppression through bare imports · New

What changed in this PR

This PR moves Android driver commands from instance fields to prototype methods so descendant drivers can override them and call super.

Changes:

• Adds command type declarations and attaches command functions to the prototype.
• Moves log commands into class overrides.
• Fixes geolocation reset to invoke the reset function.

File	Description
lib/​driver.ts	Attaches commands to the prototype and adds log overrides.
lib/​commands/​time.ts	Declares time command methods.
lib/​commands/​system-bars.ts	Declares system-bar methods.
lib/​commands/​streamscreen.ts	Declares screen-streaming methods.
lib/​commands/​shell.ts	Declares the shell method.
lib/​commands/​resources.ts	Declares resource methods.
lib/​commands/​recordscreen.ts	Declares screen-recording methods.
lib/​commands/​permissions.ts	Declares permission methods.
lib/​commands/​performance.ts	Declares performance methods.
lib/​commands/​nfc.ts	Declares the NFC method.
lib/​commands/​network.ts	Declares network methods.
lib/​commands/​misc.ts	Declares miscellaneous methods.
lib/​commands/​memory.ts	Declares the memory method.
lib/​commands/​media-projection.ts	Declares media-projection methods.
lib/​commands/​log.ts	Declares remaining log methods.
lib/​commands/​lock/​exports.ts	Declares lock methods.
lib/​commands/​legacy.ts	Declares legacy methods.
lib/​commands/​keyboard.ts	Declares keyboard methods.
lib/​commands/​intent.ts	Declares intent methods.
lib/​commands/​ime.ts	Declares input-method methods.
lib/​commands/​image-injection.ts	Declares image-injection method.
lib/​commands/​gestures.ts	Declares gesture method.
lib/​commands/​geolocation.ts	Declares geolocation methods and invokes reset.
lib/​commands/​find.ts	Declares element-finding methods.
lib/​commands/​file-actions.ts	Declares file methods.
lib/​commands/​execute.ts	Declares script-execution method.
lib/​commands/​element.ts	Declares element methods.
lib/​commands/​deviceidle.ts	Declares device-idle method.
lib/​commands/​device/​emulator-console.ts	Declares emulator-console method.
lib/​commands/​device/​emulator-actions.ts	Declares emulator-action methods.
lib/​commands/​device/​common.ts	Declares device setup methods.
lib/​commands/​context/​exports.ts	Declares context methods.
lib/​commands/​bluetooth.ts	Declares Bluetooth method.
lib/​commands/​appearance.ts	Declares appearance methods.
lib/​commands/​app-management.ts	Declares app-management methods.

🧠 Review effort: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[mykola-mokhnach]

Added test/unit/driver.spec.ts: it checks that commands are prototype (not own) properties, and that a subclass can override a command and call super. Fixed in c8e3bd6.

[mykola-mokhnach]

Fixed the lint warnings (all 16 were pre-existing, now none) in c8e3bd6.

[Copilot]

🔵 Needs a closer look

The restored geolocation reset behavior needs a regression test.

1 open finding

• Add regression test for subclass command overrides

1 resolved since last review

• Extend duplicate-import suppression through bare imports

Previously missed (1)

In code that hasn't changed since last review

Add regression test for mobileResetGeolocation reset behavior

lib/​commands/​geolocation.ts:172

mobileResetGeolocation now calls the reset helper instead of returning without doing anything, but test/unit/commands/geolocation.spec.ts only tests enabling mock location. Please add a regression test for a real device that stubs package lookup and ADB operations, calls driver.mobileResetGeolocation(), and checks that appops ... android:mock_location deny runs. This would catch a return to the previous no-op.

🧠 Review effort: Lite

[mykola-mokhnach]

Added regression tests for mobileResetGeolocation in dd4071b (checks that appops ... android:mock_location deny runs, and that it throws on emulators). The subclass-override test was added in c8e3bd6 (test/unit/driver.spec.ts).

[github-actions]

🎉 This PR is included in version 15.0.0-beta.3 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀