フォームバリデーション処理を @ablogcms/validator に共通化 - #57
Merged
Conversation
自前実装の Validator（buildIn/validator 配下）を、a-blog cms 本体が公開した @ablogcms/validator パッケージに置き換え、コア側と実装を共通化する。
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
自前実装の Validator（
themes/develop/src/js/lib/buildIn/validator配下）を、a-blog cms本体が公開した
@ablogcms/validatorパッケージに置き換え、コア側と実装を共通化する。PDFプレビュー処理を
@ablogcms/pdfに共通化した対応と同じ方針。変更内容
@ablogcms/validatorを依存に追加validator-fn.jsの import 元を自前実装から@ablogcms/validatorに変更build-in.jsの JSDoc 型参照を@ablogcms/validator/typesに更新@ablogcms/validatorは同じ API（フォーム要素を渡してインスタンス化するValidatorクラス）を提供しているため、ロジック・挙動に変更はない。