Repository navigation
Accept trailing comments in deployment migrations - #174
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #173
Summary
Deployment rejected
017-transaction-splits.sqlbecause explanatory comments follow its finalEND;. The migration is valid; the runner incorrectly required the final text character to be a semicolon. In the reported run, investment links were already applied and recorded before validation stopped, and Workers/client were not deployed.Accept trailing SQL comments without rewriting existing migration files, and prepare/validate every pending migration payload before any remote migration write.
Changes
Verification
Using pinned Node 22.23.2:
main-investment-merge,migrationsandinvestment-epic-migrationspassed against disposable Workers/D1.git diff --checkpassed; existing.sqlmigration files are unchanged.Retry after merge
Update the local main checkout and rerun the normal
npm run deploy. The runner reads recorded migration names and skips017-investment-transfer-links, then applies only missing files before deploying the selected applications. Do not remove migration history, manually replay the recorded migration or reset the database.No remote database queries/writes, production deployment, or merge was performed while implementing/testing this fix.