Skip to content

fix(ci): rerun the newest failed run for a sha, not the newest run #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewtsmith merged 1 commit into from
Oct 15, 2026
Merged

fix(ci): rerun the newest failed run for a sha, not the newest run #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/github.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,15 +337,15 @@ describe("GitHub writes", () => {
"--delete-branch",
]);
});
it("rerunFailedChecks posts to the newest run for the sha", async () => {
it("rerunFailedChecks posts to the newest failed run for the sha", async () => {
const calls: string[][] = [];
const gh = new GitHub(cfg, fakeExec(calls), false);
const sha = "aaaa1111bbbb2222cccc3333dddd4444eeee5555";
expect(await gh.rerunFailedChecks(sha)).toBe(77);
expect(calls[0]).toEqual([
"gh",
"api",
`repos/${cfg.repo}/actions/runs?head_sha=${sha}&per_page=1`,
`repos/${cfg.repo}/actions/runs?head_sha=${sha}&status=failure&per_page=1`,
"--jq",
".workflow_runs[0].id // empty",
]);
Expand All @@ -357,7 +357,7 @@ describe("GitHub writes", () => {
`repos/${cfg.repo}/actions/runs/77/rerun-failed-jobs`,
]);
});
it("rerunFailedChecks answers null when the commit has no run, and reruns nothing", async () => {
it("rerunFailedChecks answers null when the commit has no failed run, and reruns nothing", async () => {
const calls: string[][] = [];
const exec: Exec = async (cmd, args) => {
calls.push([cmd, ...args]);
Expand Down
9 changes: 6 additions & 3 deletions src/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,15 +345,18 @@ export class GitHub {
}

/**
* Reruns the failed jobs of the newest workflow run for `sha`, and answers with its run id (or
* null when GitHub has no run for that commit). REST rather than GraphQL on purpose: the
* Reruns the failed jobs of the newest FAILED workflow run for `sha`, and answers with its run id
* (or null when GitHub has no failed run for that commit). Filtered on `status=failure`, because
* the newest run for a sha is often a skipped or green workflow, and rerunning one of those is a
* 403 ("This workflow run cannot be retried") that threw before the ledger line was written, so
* the daemon retried it every tick. REST rather than GraphQL on purpose: the
* tick's GraphQL budget is for the board reads, and this only fires on a red PR.
*/
async rerunFailedChecks(sha: string): Promise<number | null> {
const found = (
await this.gh([
"api",
`repos/${this.cfg.repo}/actions/runs?head_sha=${sha}&per_page=1`,
`repos/${this.cfg.repo}/actions/runs?head_sha=${sha}&status=failure&per_page=1`,
"--jq",
".workflow_runs[0].id // empty",
])
Expand Down
Loading