Repository navigation
feat(generate): PGlite support for v1-template projects; dataDir fix - #146
Merged
Merged
Conversation
…deploy checks
- A stock v1 src/orm.config.ts (whitespace-insensitive match) is replaced
with the same config plus a DATABASE_TYPE=pglite branch, and the PGlite
packages are declared. A customized config is left alone (checks skip).
- PGLITE_DATA_DIR is passed as { dataDir }: typeorm-pglite 0.3.4 ignores a
string and runs in memory, so schema:sync and the server saw different
databases. Existing configs with the string form are rewritten.
- migrate verify --skip-build still builds when the migration isn't compiled.
Verified on prod svc 52's saved code: generate + install -> tsc 0 errors,
smoke runs (not skipped) and passes on all 9 entities, migrate generate +
verify pass for a dropped field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the pre-deploy checks run (instead of skip) on old v1 services like prod svc 52.
src/orm.config.tsis still the stock v1 file (whitespace-insensitive), generate replaces it with the same config plus aDATABASE_TYPE=pglitebranch, and declarestypeorm-pglite/@electric-sql/pglite(template versions). Customized configs are untouched; the checks keep skipping for them.schema:syncand the server used different databases ("relation does not exist"). The config now passes{ dataDir }(also works on 0.3.2), and generate rewrites the old string form in existing configs.migrate verify --skip-buildbuilds anyway when the migration isn't compiled (it otherwise ran nothing and reported drift).Verified on svc 52's saved code: generate + npm install → tsc 0 errors, build ok;
test smokeruns and passes on all 9 entities;migrate generate+migrate verifypass for a dropped field. 376 tests, lint 0 errors.