Repository navigation
fix(generate): drop a plain index where a unique one covers the same columns - #149
Merged
Merged
Conversation
…columns TypeORM names an index from its table and columns only, so a plain and a unique index on the same columns get one name; the second CREATE INDEX fails and schema:sync rolls back (prod svc 52, Warehouse.manager_email). The parser now keeps the unique index and drops the plain one and exact duplicates, for every language.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prod svc 52's schema has both
{fields:[manager_email]}and{fields:[manager_email], unique:true}on Warehouse. TypeORM names bothIDX_2fab7864…, so the second CREATE INDEX fails (42P07) and schema:sync rolls back.apso test smokecaught it before a real first deploy hit it.parseApsorcV2now runsdedupeIndexeson every entity: the unique index is kept (it serves lookups too), the plain one and exact duplicates are dropped. Applies to TS, Python and Go.Verified on svc 52's current schema: released 0.42.0 fails at schema; with this change generate + build +
test smokepass on all entities. New unit test; 377 tests, lint 0 errors.