Repository navigation
Bundle Node 24.22.1 LTS in standalone tarballs and smoke test them - #159
Merged
Merged
Conversation
…them Node 18.20.4 reached end of life in April 2025. The tarballs now bundle Node 24.22.1 (LTS, supported until April 2028), and CI builds and tests on 24, with unit tests also run on 22. scripts/tarball-smoke.sh unpacks a tarball and checks the bundled Node version, --help, schema validate and the PGlite migrate sandbox. It runs on PRs that change the bundle and in the release job before any upload.
Homebrew 6 ignores untrusted third-party taps. brew install apsoai/tap/apso trusts just that formula; the short name fails until the user runs brew trust. Existing installs need brew trust --formula apsoai/tap/apso.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Homebrew/standalone tarballs bundled Node 18.20.4, which reached end of life in April 2025. Nothing ran the tarball before release, so a broken bundle would only show up for users.
What
oclif.update.node.version: 18.20.4 -> 24.22.1 (LTS, supported until April 2028).node --version= v22.22.3.scripts/tarball-smoke.sh: unpacks a tarball and checks the bundled Node is the pinned version,--help,schema validateontest/fixtures/inventory-multi-fk.apsorc, and the PGlitemigratesandbox.tarball-smoke.ymlon PRs that changepackage.json, the lockfile or the script.enginesstays>=18.0.0for npm installs.Tested
scripts/tarball-smoke.sh darwin-arm64passes locally on the packed tarball (bundled node v24.22.1, 29 statements tested in PGlite, 54 s).