Repository navigation
fix: serve generated routes; install greenlet for async SQLAlchemy - #7
Merged
Merged
Conversation
main.py never included app.autogen's autogen_router, so a generated Python service served no entity routes. The template's app/autogen/__init__.py now defines an empty router so the import works before the first apso generate. SQLAlchemy 2.1 no longer installs greenlet, which the asyncio extension needs, so the app failed to import. Depend on sqlalchemy[asyncio].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs that stopped every generated Python service from working:
app/main.pynever includedautogen_router, so no entity route was served. It now includes it;app/autogen/__init__.pyships an empty router so the import works before the firstapso generate(which overwrites that file).greenlet, and the asyncio extension needs it, soapp.mainfailed to import. The dependency is nowsqlalchemy[asyncio].Tested:
pytest testspasses (2 tests) on Python 3.12 with SQLAlchemy 2.1.6; the CLI auth smoke (apsoai/cli feat/jwt-auth) runs CRUD against a generated service on Postgres.