Repository navigation
Add the fork's KWin RPM spec and its build script - #29
Merged
Merged
Conversation
The full profile's pinned compositor: the Fedora kwin.spec with the fork's identity — the pfN distag (the stock release plus the fork's sequence number), the GitHub tagged archive as the source, and the fork's changelog entry. The build script downloads the tagged archive, extracts the stock sources the spec needs, and runs rpmbuild. The subpackages are kwin, kwin-common, kwin-libs, kwin-devel and kwin-doc at the pfN distag, matching the metapackage's exact-EVR requires. Signed-off-by: Wisbendji Fimerlus <archledger236@gmail.com>
build-fork-rpm.sh could not build from a real tag:
- It took the sequence number with ${TAG##*.pf}, which matches
nothing in v6.8.2-pf3, so every pf tag was refused.
- Its --define version and --define distag had no effect: the spec's
own Version: and Release: lines win. The spec now takes the
sequence number as the macro pf (default 3) for its release and
its source, and the script passes the tag's. A tag of another
upstream version than the spec's is refused.
- GitHub's archive of v6.8.2-pf3 unpacks to kwin-6.8.2-pf3, not to
the kwin-6.8.2 that %autosetup expects by default.
- It fetched Fedora's patch c9d7207 (compositor: handle possibly
missing render device). The fork's 6.8.2 line has that commit in
its source, and applying it again fails; the spec no longer lists
it.
SRPM=1 builds the source package only, the input of the Copr
project. The first changelog entry's weekday is corrected
(2026-11-12 is a Thursday).
Signed-off-by: Wisbendji Fimerlus <archledger236@gmail.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The spec and the build script for the fork's KWin packages, the pinned compositor of the full profile (archledger/plasma-fusion ADR 0001). Two commits; no source file of KWin changes.
packaging/fedora/kwin-fusion.spec: Fedora 44'skwin.specwith the fork's identity. The release carries the fork's sequence number as the suffix.pfN(macropf, default 3:6.8.2-3.fc44.pf3), the source is the fork's tagged archive as GitHub serves it (it unpacks tokwin-6.8.2-pf3), and Fedora's patch c9d7207 is not listed: the 6.8.2 line has that commit in its source.packaging/fedora/build-fork-rpm.sh TAG [OUTPUT_DIR]: downloads the tagged archive and builds the packages;SRPM=1builds the source package only, the input of the Copr project. It takes the sequence number from the tag and refuses a tag of another upstream version than the spec's.Verification
kwin,kwin-common,kwin-libs,kwin-devel,kwin-docand the debug packages at6.8.2-3.fc44.pf3, three builds from the 6.8.2 line;rpm -Kdigests verified; installed on the ThinkPad X13 Yoga and in a Fedora 44 virtual machine withdnf reinstall,rpm -Vclean.git archiveof the line with the same top directory, not from GitHub's archive of a tag: the tagv6.8.2-pf3does not exist yet. The script's download and theSRPM=1path run for the first time with the tag.