Repository navigation
Let the current provider settle a record its predecessor left - #32
Merged
Merged
Conversation
A released record could end only through the provider that admitted the window. When that provider retired first, nothing could ever end the record. This happens when the placement script is unloaded or reloaded after a release, before it settled: its teardown's restore never started, the user moved the window while the restore was in flight, or the script stopped without its teardown. The window kept its record until it closed and could not be tiled again (plasma-fusion#175). settleReleasedTransientOwnership now also accepts the writer's current provider once the admitting provider has retired. The caller must be registered; another provider than the admitting one only while the admitting one is not. Every evidence condition is unchanged: no live restoration, an ordinary mode outside every tile, settled geometry, and the window on its floating frame or where the user's own move or resize left it. A live restoration is still nobody's to settle, so a reloaded provider never takes a window over a record in flight. testTransientTilingFacadeReleasedMaster gains a successor column and five rows: a removed desktop, the user's move, a second window of the app, a removed output and the work area's re-check. In each, the admitting provider is destroyed after the release and a new one registers. The first's token settles nothing; the new provider returns the window and settles it as the first would have, and admits it again. The five rows fail without the change: settle answers StaleProvider. Signed-off-by: Wisbendji Fimerlus <archledger236@gmail.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 14, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Once the provider that admitted a window has retired, the writer's current provider may settle the window's released record, under the same evidence as before. Until now only the admitting provider could, so a record its provider left behind lasted until the window closed, and the window could not be tiled again (archledger/plasma-fusion#175).
When it happens
The placement script is unloaded or reloaded after a release and before it settled the record:
The reloaded script finds the record (
floatingFrameanswers), butsettleWindowrefused it as another provider's (2).The change
Window::settleReleasedTransientOwnership:Every evidence condition is unchanged:
NotReleased;The writer finalizes as before. The doc comments in
window.handtransienttilingapi.hsay so.Tests
testTransientTilingFacadeReleasedMastergains asuccessorcolumn and five rows:desktop-removed-successor,moved-by-hand-successor,key-conflict-successor,output-removed-successorandre-checked-by-the-workspace-successor. In each, the admitting provider is destroyed after the release and a new one registers. Then:StaleProvider, and so does a random token;Without the change the five rows fail: settle answers
StaleProviderto the new provider. The other 16 rows are unchanged.The script's side
The placement script's start ends such records (
tiler.adoptStranded): the window goes back to the floating frame the record holds, unless the user put it where it stands, and is settled. On a fork without this change the settle answers 2 and the script leaves the window alone, as before.