Repository navigation
fix(ui): [hidden] global defensive rule — inline-edit display no longer overrides hidden attr (v1.19.1) - #64
Merged
Conversation
…er overrides hidden attr (v1.19.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug fix — settings page "生成新 Key" (Generate New Key) inline form was visible on page load without clicking the button (rant
2026-08-17T21:36:27).Root cause:
.inline-edit { display: inline-flex; }(style.css) overrides the UA stylesheet's[hidden] { display: none }— thehiddenattribute on#ak-new-inlinelost to the author rule with higher specificity, so the form was always shown.Fix: add a global defensive rule next to
.hidden:!importantbeats any authordisplayrule regardless of specificity/order — thehiddenattribute now always wins (covers future components too)hiddenattribute path is affected; elements using the.hiddenclass (help panel, views, etc.) keep their existing behaviorPer rant: branch
feat/fix-inline-edit-hidden, no version bump (v1.19.1).Rant (verbatim)
Related
2026-08-17T21:36:27.606368(projectaitokenpool, status in_progress)feat/fix-inline-edit-hidden(per rant)Tests
[hidden]rule +!important, positioning near.hidden, HTML/JS wiring, no regression on other hidden elements)cargo test— 1 passedcargo fmt --check