ci: pin actions to commit SHAs and lint workflows - #56
Merged
Merged
Conversation
Every third-party `uses:` now carries a full commit SHA with a version comment, the form Dependabot reads to keep the pins fresh. lean-update's `dev` and the shared ci-workflows actions on `main` are branch refs with no tag to pin to; `.github/pinact.yaml` exempts them and `.github/zizmor.yml` gives them a ref-pin policy. A `lints` job calls ci-workflows' lint-workflows action (actionlint, shellcheck over composite action scripts, pinact check and verify, zizmor). Getting zizmor clean: the CI workflow declares `contents: read` instead of inheriting the repository default, every checkout sets `persist-credentials: false` (lean-update pushes through its own token input, not the checkout's git credentials), the Nix installer reads `github.token`, and Dependabot gets the 7-day cooldown zizmor requires. Dependabot now also covers the Rust crate under `rust/`, which had no cargo ecosystem entry. The valgrind job restored a cache from `test/.lake` keyed on a `test/lake-manifest.json` that does not exist, so it always rebuilt from scratch; it now restores the root `.lake` under the key lean-action saves in the lean-test job.
samuelburnham
enabled auto-merge (squash)
October 1, 2026 17:06
arthurpaulino
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every third-party
uses:now carries a full commit SHA with a version comment, the form Dependabot reads to keep the pins fresh. lean-update'sdevand the shared ci-workflows actions onmainare branch refs with no tag to pin to;.github/pinact.yamlexempts them and.github/zizmor.ymlgives them a ref-pin policy.A
lintsjob calls ci-workflows' lint-workflows action (actionlint, shellcheck over composite action scripts, pinact check and verify, zizmor). Getting zizmor clean: the CI workflow declarescontents: readinstead of inheriting the repository default, every checkout setspersist-credentials: false(lean-update pushes through its own token input, not the checkout's git credentials), the Nix installer readsgithub.token, and Dependabot gets the 7-day cooldown zizmor requires.Dependabot now also covers the Rust crate under
rust/, which had no cargo ecosystem entry. The valgrind job restored a cache fromtest/.lakekeyed on atest/lake-manifest.jsonthat does not exist, so it always rebuilt from scratch; it now restores the root.lakeunder the key lean-action saves in the lean-test job.