Repository navigation
Keep a silent estimate silent when scaling to the mixture - #720
Merged
Merged
Conversation
A source of all zeros was divided by its peak and came back as NaN.
Collaborator
|
Thanks a lot ! |
Contributor
Author
|
Thanks a lot, glad this one landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalize_estimatesof a silent source and a mixture peaking at0.5returnedNaN. The source was scaled by the mixture peak divided by its own peak, and that peak is0. It now stays0. A source peaking at1still scales to[0.5, -0.25].Test plan
tests/dsp/normalization_test.pyNaN0, and the other source still matches the mixture peak