fix: add timeout and use HEAD for registry URL validation - #2130
Conversation
When --registry-url points to an unreachable host, the CLI hangs indefinitely because fetch() has no timeout and uses GET. This adds: - 5-second timeout via AbortController - HEAD method instead of GET for lightweight validation - Specific error message for timeout vs other network errors Fixes asyncapi#2027 Co-Authored-By: Paperclip <noreply@paperclip.ing>
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
1 participant
Summary
AbortControllertoregistryValidation()fetch callGETtoHEADfor lightweight registry reachability checkRoot Cause
fetch()insrc/utils/generate/registry.tshad no timeout and no abort signal, causing the CLI to hang indefinitely when--registry-urlpoints to an unreachable host (e.g., blackholed IP).Test Plan
http://10.255.255.1) — CLI now exits with timeout error after 5sFixes #2027