Skip to content

fix: prevent double-stringification of AsyncAPI string in archiver service (#2026) - #2134

Open
useye wants to merge 1 commit into
asyncapi:masterfrom
useye:fix/issue-2026-archiver-stringify
Open

fix: prevent double-stringification of AsyncAPI string in archiver service (#2026)#2134
useye wants to merge 1 commit into
asyncapi:masterfrom
useye:fix/issue-2026-archiver-stringify

Conversation

@useye

@useye useye commented Apr 22, 2026

Copy link
Copy Markdown

Summary

In src/domains/services/archiver.service.ts, the appendAsyncAPIDocument method always called JSON.stringify(asyncapi) even when asyncapi was already a string. This caused valid AsyncAPI YAML/JSON strings to be double-serialized, resulting in invalid documents in the generated zip archive.

Fix

Changed appendAsyncAPIDocument to only stringify when the input is an object:

const content =
  typeof asyncapi === 'string' ? asyncapi : JSON.stringify(asyncapi);

Also updated the method signature to accept string | object instead of just string.

Related Issue

Fixes #2026

@changeset-bot

changeset-bot Bot commented Apr 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a19a992

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions Bot added the stale label Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

[BUG] : AsyncAPI document is double-stringified in generated ZIP output

1 participant