no hardcoded pathes for libabc.so - #49
Open
olerichter wants to merge 1 commit into
Open
olerichter wants to merge 1 commit into
olerichter wants to merge 1 commit into
Conversation
This was referenced Sep 3, 2026
Member
Author
|
It compiles fine on linux, but i dont have a mac to test macos (reqested from my it department) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
switch build script includes for libabc.so to the customary linker autodiscovery from a hardcoded path
Description of change
removes the hardcoded path form the build commands in make
Purpose of this change
enable robust so finding for runtime linkers
How has this been tested?
build on RHEL7 and 9 and run act test suite on debian, ubuntu, RHEL derivates, Fedora, Arch and Suse
Checklist:
@rmanohar his uses the search path for finding the so, otherwise the path gets backed into the binary making my build process fails.
It uses -l:libabc.so and not -labc to explicitly link the so and not the static variant
requires: asyncvlsi/act#57